Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 5.0 will become a default .NET version on December, 14 #1891

Closed
7 of 9 tasks
AlenaSviridenko opened this issue Oct 23, 2020 · 29 comments
Closed
7 of 9 tasks

.NET 5.0 will become a default .NET version on December, 14 #1891

AlenaSviridenko opened this issue Oct 23, 2020 · 29 comments

Comments

@AlenaSviridenko
Copy link
Contributor

AlenaSviridenko commented Oct 23, 2020

Breaking changes

.NET 5.0 will become a default .NET version on macOS and Ubuntu (Windows already contains .NET 5.0 as a default, it came along with Visual Studio 16.8)

Target date

Deployment of these changes will start on December 7 December, 14 and will take 3-4 days. (date is moved due to deployments freeze on a week of December, 7)

The motivation for the changes

We would like to provide the latest .NET by default on images.

Possible impact

All pipelines that are not using actions/setup-net-core-sdk action for GitHub Actions or Use .NET Core task for Azure Pipelines might be affected due to a lot of possible breaking changes in new .NET version

  • Ubuntu 16.04
  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.13
  • macOS 10.14
  • macOS 10.15
  • macOS 11.0
  • Windows Server 2016 R2
  • Windows Server 2019

Mitigation ways

Please consider using of actions/setup-net-core-sdk action for GitHub Actions or Use .NET Core task for Azure Pipelines to specify the needed .NET version.

The list of all available .NET versions can be found in corresponding documentation:

@ManuelGalindo
Copy link

Is there a test branch to do some internal testing

@AlenaSviridenko
Copy link
Contributor Author

@ManuelGalindo unfortunately, this is not available in public yet and will become available after the official release.

@alepauly
Copy link
Contributor

alepauly commented Nov 5, 2020

I've updated the date. Once released publicly .NET 5.0 will be available by using the setup-dotnet Action in GitHub or the UseDotNet task in Azure DevOps.

@alepauly alepauly changed the title .NET 5.0 will become a default .NET version on November, 10 .NET 5.0 will become a default .NET version the week of November 16, 2020 Nov 6, 2020
@alepauly
Copy link
Contributor

alepauly commented Nov 6, 2020

Is there a test branch to do some internal testing

@ManuelGalindo we've delayed this by a week but you should be able to use setup-dotnet in GitHub Actions or UseDotNet in Azure Pipelines to test .NET 5 once it's launched during .NET Conf.

@Tratcher
Copy link

Tratcher commented Nov 6, 2020

Will this also include the required update of VS to 16.8?

@DrGriff
Copy link

DrGriff commented Nov 23, 2020

"date will be defined later"

Could a date be confirmed please? I'd like to stop actively checking this and just add a date to my diary for when I can remove the UseDotNet step. Many thanks.

@AlenaSviridenko
Copy link
Contributor Author

Hi @DrGriff ,
it is already available on Windows images since VS 16.8 brought it with itself.
On Ubuntu and macOS images it will be added approximately in 2 weeks. But we are recommending keep using UseDotNet step even after it, just to be sure that your build won't be broken if the default .NET will change.

@SimonCropp
Copy link

But we are recommending keep using UseDotNet step even after it, just to be sure that your build won't be broken if the default .NET will change.

if that is the recommendation, then there is no point having dotnet on the default image. also doesnt UseDotNet significantly slow down a build, and also waste a non trivial amount of resources?

@MatthewSteeples
Copy link

@SimonCropp UseDotNet adds 3 seconds on our Azure Hosted builds (because what we're after is already installed, but it will install it if it isn't)

@SimonCropp
Copy link

@MatthewSteeples what will the impact be when the default dotnet on the VMs is 5.1?

@MatthewSteeples
Copy link

In theory if it's one of the ones off these lists (Windows, Ubuntu, Mac) then it should just be a few seconds. It's when you want one that's newer than is available on the server that causes the delay

@AlenaSviridenko AlenaSviridenko changed the title .NET 5.0 will become a default .NET version soon [date will be defined later] .NET 5.0 will become a default .NET version on December, 7 Nov 25, 2020
@AlenaSviridenko AlenaSviridenko changed the title .NET 5.0 will become a default .NET version on December, 7 .NET 5.0 will become a default .NET version on December, 14 Nov 27, 2020
@mikeblakeuk
Copy link

mikeblakeuk commented Dec 14, 2020

Give Monday 14 Dec (aka Dec 14) 2020
When using vmImage: 'ubuntu-20.04'
and Agent name: 'Azure Pipelines 4'
and Agent machine name: 'fv-az879-972'
and Current agent version: '2.179.0'

then this fails with (SDK Version: 3.1.404)

##[error]/usr/share/dotnet/sdk/3.1.404/Microsoft.Common.CurrentVersion.targets(1177,5): Error MSB3644: The reference assemblies for .NETFramework,Version=v5.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

We could add the installer, but whats the point? It takes time and if a latest .net fails, we want to know.

Also, there is a side affect of using the installer that it changes the .net probing path so if you have 5.0 and 3.1 you need to install both

Please update the agents with the latest .net 5.0

Thanks
cc @AlenaSviridenko

Update:
"Deployment of these changes will start on December, 14 and will take 3-4 days." So i need to wait until the 18th :(

@AlenaSviridenko
Copy link
Contributor Author

AlenaSviridenko commented Dec 14, 2020

@mikeblakeuk , based on our current deployment progress, Ubuntu images with .NET 5.0 will likely be fully deployed late 16th if there will be no unexpected issues.
Unfortunately, we cannot update all agents at once due to possible capacity issues and infrastructure, so we have to do it iteratively.

peppy added a commit to peppy/osu-server-spectator that referenced this issue Dec 16, 2020
We didn't have any CI until now, so this is the bare minimum. Using the
windows build agent as it has been updated to net5.0 (unlike linux,
which is [currently in
rollout](actions/runner-images#1891 (comment))).

Note that ppy#4 should be
merged first to fix a compilation error.
Cyberboss added a commit to tgstation/tgstation-server that referenced this issue Dec 16, 2020
@Cyberboss
Copy link

Cyberboss commented Dec 17, 2020

I've been experiencing intermittent issues restoring nuget packages on windows-latest over the past week. Is this related?

https://github.com/tgstation/tgstation-server/pull/1164/checks?check_run_id=15737103821

Build FAILED.

D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package BetterWin32Errors. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Byond.TopicSender. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Cyberboss.AspNetCore.AsyncInitializer. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Cyberboss.SmartIrc4net.Standard. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Discord.Net.WebSocket. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package GitLabApiClient. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
...

And many others

@nullpainter
Copy link

I've been experiencing intermittent issues restoring nuget packages on windows-latest over the past week. Is this related?

https://github.com/tgstation/tgstation-server/pull/1164/checks?check_run_id=15737103821

Build FAILED.

D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package BetterWin32Errors. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Byond.TopicSender. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Cyberboss.AspNetCore.AsyncInitializer. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Cyberboss.SmartIrc4net.Standard. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package Discord.Net.WebSocket. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
D:\a\tgstation-server\tgstation-server\src\Tgstation.Server.Host\Tgstation.Server.Host.csproj : error NU1101: Unable to find package GitLabApiClient. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\tgstation-server\tgstation-server\tgstation-server.sln]
...

And many others

Same for me, FWIW:

\a\sanchez\sanchez\Sanchez.Workflow\Sanchez.Workflow.csproj : error NU1101: Unable to find package Serilog. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\sanchez\sanchez\Sanchez.sln]
D:\a\sanchez\sanchez\Sanchez.Workflow\Sanchez.Workflow.csproj : error NU1101: Unable to find package ShellProgressBar. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\sanchez\sanchez\Sanchez.sln]
D:\a\sanchez\sanchez\Sanchez.Workflow\Sanchez.Workflow.csproj : error NU1101: Unable to find package WorkflowCore. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\sanchez\sanchez\Sanchez.sln]
D:\a\sanchez\sanchez\Sanchez.Workflow\Sanchez.Workflow.csproj : error NU1101: Unable to find package SonarAnalyzer.CSharp. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\sanchez\sanchez\Sanchez.sln]
D:\a\sanchez\sanchez\Sanchez.Workflow\Sanchez.Workflow.csproj : error NU1101: Unable to find package Ardalis.GuardClauses. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\sanchez\sanchez\Sanchez.sln]
D:\a\sanchez\sanchez\Sanchez.Workflow\Sanchez.Workflow.csproj : error NU1101: Unable to find package FluentValidation. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\sanchez\sanchez\Sanchez.sln]
D:\a\sanchez\sanchez\Sanchez.Workflow\Sanchez.Workflow.csproj : error NU1101: Unable to find package Microsoft.Extensions.DependencyInjection.Abstractions. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages...

@Cyberboss
Copy link

Cyberboss commented Dec 20, 2020

Related issue with work around actions/setup-dotnet#155

Viir added a commit to pine-vm/pine that referenced this issue Dec 21, 2020
Avoid these errors that recently started appearing in GitHub actions Windows environment:

```
[...]
D:\a\elm-fullstack\elm-fullstack\implement\PersistentProcess\PersistentProcess.WebHost\PersistentProcess.WebHost.csproj : error NU1101: Unable to find package Mono.Posix.NETStandard. No packages exist with this id in source(s): Microsoft Visual Studio Offline Packages [D:\a\elm-fullstack\elm-fullstack\implement\test-elm-fullstack\test-elm-fullstack.csproj]
34D:\a\elm-fullstack\elm-fullstack\implement\PersistentProcess\PersistentProcess.WebHost\PersistentProcess.WebHost.csproj : error NU1102: Unable to find package System.Collections.Immutable with version (>= 1.7.1) [D:\a\elm-fullstack\elm-fullstack\implement\test-elm-fullstack\test-elm-fullstack.csproj]
35D:\a\elm-fullstack\elm-fullstack\implement\PersistentProcess\PersistentProcess.WebHost\PersistentProcess.WebHost.csproj : error NU1102: - Found 2 version(s) in Microsoft Visual Studio Offline Packages [ Nearest version: 1.2.0 ] [D:\a\elm-fullstack\elm-fullstack\implement\test-elm-fullstack\test-elm-fullstack.csproj]
36Error: Process completed with exit code 1.
```

Integrate the workaround discovered by Jordan Brown, Gewoon Jaap, et al.

For context, see:

+ actions/setup-dotnet#155
+ actions/runner-images#1891
@AlenaSviridenko
Copy link
Contributor Author

Images are deployed everywhere, if you see any issues - please, file a new ticket.
Closing this one.

@muhammedazheruddin
Copy link

Hi all,

I'm learning ASP.NET CORE and getting this error while running the command "dotnet run" in my sandbox. Request you to kindly guide me here for the resolution.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests