feat: Add basic msp file reading functionality #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality was something that I needed, and it seems to be working fine (from my limited testing).
There are no tests for it yet, and it is a bit simple (file tab does not work, but all others seem to be working the same as for .msi files)
@activescott is this something that you are interested in?
If so, please list what you would like me to add/improve.
Did not do these (yet):
ps: I have not forgotten about my older PR's, will get to address those eventually.
Testing was done on the .msp files from the German version of Microsoft's Excel Viewer available at:
https://web.archive.org/web/20170104231942if_/http://download.microsoft.com/download/F/8/8/F88CB355-ECAA-4B74-87D6-C05C81D215BF/ExcelViewer.exe