Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename private-network-access feature #320

Merged
merged 5 commits into from
Apr 9, 2023
Merged

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Apr 9, 2023

PR Type

Spec Alignment

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Align with spec changes.

https://wicg.github.io/private-network-access -> https://wicg.github.io/local-network-access

@robjtede robjtede added A-cors Project: actix-cors B-semver-patch labels Apr 9, 2023
@robjtede robjtede changed the title Local-network-access cors: rename private-network-access feature Apr 9, 2023
@robjtede robjtede changed the title cors: rename private-network-access feature rename private-network-access feature Apr 9, 2023
@robjtede robjtede merged commit 111d95e into master Apr 9, 2023
@robjtede robjtede deleted the local-network-access branch April 9, 2023 18:35
@latin-1
Copy link

latin-1 commented Apr 9, 2023

I don't believe we should do it right now.

WICG/private-network-access#91 (comment)

Given that we don't want to discourage developers from adopting security improvements, we believe that it's in users' and developers' best interest to keep the existing header names, Access-Control-Allow-Private-Network and Access-Control-Request-Private-Network, and we have decided to do so in our implementation. We'll undo WICG/private-network-access#97 to match that reality.

@robjtede
Copy link
Member Author

robjtede commented Apr 9, 2023

Thanks for surfacing that comment so quickly. I haven't cut a release so will get it reverted soon.

robjtede added a commit that referenced this pull request Apr 9, 2023
@robjtede
Copy link
Member Author

robjtede commented Apr 9, 2023

reverted in 8a31f30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cors Project: actix-cors B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants