Bump bundled nlohmann::json to commit 84f19d6 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a gcc10 compilation issue that got resolved in [acts-project#2034](nlohmann/json#2034). There has not been a tag since this was merged so I'm bumping the bundled version to the develop branch immediately after that PR went in.
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 44.88% 44.88%
=======================================
Files 369 369
Lines 18451 18451
Branches 8737 8737
=======================================
Hits 8281 8281
Misses 4861 4861
Partials 5309 5309 Continue to review full report at Codecov.
|
|
@paulgessinger Could you rebase? |
|
I can but it should b safe to do a squash and merge in this case. |
|
Yes, true. |
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
There is a gcc10 compilation issue that got resolved in [acts-project#2034](nlohmann/json#2034). There has not been a tag since this was merged so I'm bumping the bundled version to the develop branch immediately after that PR went in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a gcc10 compilation issue that got resolved in
#2034. There has not been
a tag since this was merged so I'm bumping the bundled version to the
develop branch immediately after that PR went in.