Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pin names #82

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Change pin names #82

merged 2 commits into from
Mar 21, 2024

Conversation

tekktrik
Copy link
Member

Changes remaining short pin names to match the rest of the library. I couldn't find any Learn guide examples that used these arguments by name (or used anything besides the default).

@tekktrik tekktrik linked an issue Mar 21, 2024 that may be closed by this pull request
@tekktrik tekktrik force-pushed the dev/change-arg-name branch from 8b81318 to 142841f Compare March 21, 2024 16:56
@tekktrik tekktrik force-pushed the dev/change-arg-name branch from 142841f to 7204a35 Compare March 21, 2024 16:59
@tekktrik tekktrik force-pushed the dev/change-arg-name branch from a53d4df to 164d702 Compare March 21, 2024 18:07
@tekktrik tekktrik requested a review from a team March 21, 2024 18:11
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit f378b41 into adafruit:main Mar 21, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 26, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.6.2 from 1.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#20 from FoamyGuy/display_root_group_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.4.2 from 1.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#23 from DJDevon3/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.0 from 3.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#203 from FoamyGuy/outlined_label

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.15.2 from 1.15.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#82 from tekktrik/dev/change-arg-name

Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.21 from 1.2.20:
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#41 from FoamyGuy/json_key_file_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library uses short argument names
2 participants