Update HX8357 driver to 8.x/9.x transitional code #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TFT FEatherwing display driver needs updating for 9.0
tekktrik
reviewed
Mar 24, 2024
adafruit_hx8357.py
Outdated
| """HX8357D driver""" | ||
|
|
||
| def __init__(self, bus: displayio.FourWire, **kwargs) -> None: | ||
| def __init__(self, bus: FourWire.FourWire, **kwargs) -> None: |
There was a problem hiding this comment.
The type annotation now just be FourWire, but this is great, thanks!
tekktrik
requested changes
Mar 24, 2024
|
Thanks! I helped someone in discord with this exact issue last night and never dawned on me to check the typing I set here. Doh! Also got Github Desktop sorted out. It's submitting all line endings in LF format only. No more thousands of pylint CRLF line ending errors. |
tekktrik
approved these changes
Mar 25, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 26, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.6.2 from 1.6.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#20 from FoamyGuy/display_root_group_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#23 from DJDevon3/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.0 from 3.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#203 from FoamyGuy/outlined_label Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.15.2 from 1.15.1: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#82 from tekktrik/dev/change-arg-name Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.21 from 1.2.20: > Merge pull request adafruit/Adafruit_CircuitPython_RSA#41 from FoamyGuy/json_key_file_example Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.5" TFT Featherwing display driver needs updating for 9.0. Added 8.x to 9.x transitional code so it should work in either 8.x or 9.x Only tested in 9.x, needs 8.x testing. In 9.x the previous driver commit would bring up future warnings.
These are now addressed with this commit and no warnings are present while using 9.0