Skip to content

Commit

Permalink
Fix protobuffers build by reenabling allowJs (bazel-contrib#359)
Browse files Browse the repository at this point in the history
As part of bazel-contrib#358, I removed the `allowJs` setting from the
`tsconfig.json`. I didn't know why we needed `allowJs` and
everything seemed to still work smoothly.

However, when trying to build the extension from a completely fresh git
checkout, I realized that the `protos.js` file was missing from the
`out` directory. With `allowJs: false` the `src/protos/protos.js` file
was no longer copied to the `out` directory. This only worked locally
for me, because the current build is not hermetic.
  • Loading branch information
vogelsgesang authored Apr 1, 2024
1 parent afc3aed commit 75705f8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"sourceMap": true,
"rootDir": ".",
"strict": true,
"strictNullChecks": false
"strictNullChecks": false,
"allowJs": true,
},
"exclude": [
"node_modules",
Expand Down

0 comments on commit 75705f8

Please sign in to comment.