Refresh FedProx MNIST baseline #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e general config; fixes to results generation
…flagged as stragglers (and not using FedProx)
jafermarq
requested review from
pedropgusmao,
tanertopal and
danieljanes
as code owners
…functions to `dataset_preparation.py`; other minor changes
…to new template [WIP]
danieljanes
requested changes
Jun 30, 2023
Co-authored-by: Daniel J. Beutel <daniel@adap.com>
danieljanes
approved these changes
Jul 6, 2023
tanertopal
added a commit
that referenced
this pull request
Jul 11, 2023
* main: Add new baselines test github workflow (#2009) Add simulation to E2E tests (#2074) Add E2E test for Pandas (#2070) Add E2E test for scikit-learn (#2073) Add format and test scripts (#1987) Add missing ruff dependency to baselines (#2075) Add E2E test for MXNet (#2069) Add E2E test for Jax (#2067) Update bare E2E test client (#2068) Update PyTorch E2E test (#2072) Update Tensorflow E2E test (#2071) Fix flake8 error E266 in baseline template (#2065) Fix baseline creation on linux-based systems (#2063) Updates to Baseline Template Readmes (#2059) Refresh FedProx MNIST baseline (#1918) Extend test checking tools config (#1986) Improved documentation (#2006) updated material for 30min FL tutorial (#2005) Update codeowners list (#2004) Create and delete nodes via Fleet API (#1901)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding some extra functionality to the FedProx-MNIST baseline. The main idea behind the changes and new code is to make it replicate the MNIST results in the FedProx paper. List of changes:
models/LogisticRegressionstragglersthey should be discarded from aggregation. This is done with a custom strategy.datasets._balance_classes()so I fixed it