Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test checking tools config #1986

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Conversation

adam-narozniak
Copy link
Member

Issue

The testing tools configuration for baseline is not full.

Description

NA

Related issues/PRs

NA

Proposal

Extend the config in pyproject.toml by coping the flower's pyproject.toml config file.
One change:

  • mypy strict is False.

Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. @jafermarq wdyt?

@tanertopal tanertopal added this pull request to the merge queue Jul 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 4, 2023
@adam-narozniak adam-narozniak enabled auto-merge (squash) July 5, 2023 08:19
@adam-narozniak adam-narozniak merged commit 790fb70 into main Jul 6, 2023
@adam-narozniak adam-narozniak deleted the extend-test-config-baselines branch July 6, 2023 10:23
tanertopal added a commit that referenced this pull request Jul 11, 2023
* main:
  Add new baselines test github workflow (#2009)
  Add simulation to E2E tests (#2074)
  Add E2E test for Pandas (#2070)
  Add E2E test for scikit-learn (#2073)
  Add format and test scripts (#1987)
  Add missing ruff dependency to baselines (#2075)
  Add E2E test for MXNet (#2069)
  Add E2E test for Jax (#2067)
  Update bare E2E test client (#2068)
  Update PyTorch E2E test (#2072)
  Update Tensorflow E2E test (#2071)
  Fix flake8 error E266 in baseline template (#2065)
  Fix baseline creation on linux-based systems (#2063)
  Updates to Baseline Template Readmes (#2059)
  Refresh FedProx MNIST baseline (#1918)
  Extend test checking tools config (#1986)
  Improved documentation (#2006)
  updated material for 30min FL tutorial (#2005)
  Update codeowners list (#2004)
  Create and delete nodes via Fleet API (#1901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants