Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #591 #592

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Fix #591 #592

merged 4 commits into from
Aug 20, 2024

Conversation

eb1
Copy link
Contributor

@eb1 eb1 commented Aug 20, 2024

Fixes #591 .

Changes proposed in this request:

  • Main fix for issue Adapting: duplicate phrase entries #591 is to turn source phrase insert/update calls into async calls (with a deferred / promise), so the call stack isn't blocked. This reduces the size of the call stack.
  • Capital source text inside punctuation wasn't being processed properly -- fixed.
  • Disable prev/next, placeholder after buttons on deselect
  • Check for typeahead value change before marking dirty bit on unselectedAdaptation()

- Disable prev/next, placeholder after buttons on deselect
- Check for typeahead value change before marking dirty bit on unselectedAdaptation()
Capital source text inside punctuation wasn't being processed properly -- fixed.
- Make sourcephrase create/update calls async w/deferred. Ran into a stack overflow error at the pile I had encountered some duplicate entries -- this _might_ have been the cause of the dups. Still need to run tests for a while.
- Replace some obsolete event methods with trigger() calls.
@eb1 eb1 merged commit c304427 into adapt-it:master Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapting: duplicate phrase entries
1 participant