[Slider#204] Added snapshot tests + corrected CGColor not updating on traitCollectionDidChange + added comments on functions using CGLayers like applyShadow #677
Conversation
[Slider#204] Colors & shapes + use cases
[Slider#204] Started ViewModel + Added SliderGetClosestValueUseCase
…e (UISlider does indeed trigger a newValue even if the old one is equal to the new one)
[Slider#204] Implementation of SliderUIControl
LouisBorleeAdevinta
force-pushed
the
204-component-slider-develop
branch
from
613360e
to
6429a81
Compare
| private func _test(scenario: SliderScenario) { | ||
| let configurations = self.createConfigurations(from: scenario) | ||
| for configuration in configurations { | ||
| self.assertSnapshot(matching: configuration.view, modes: scenario.modes, sizes: [.medium], testName: configuration.testName) |
There was a problem hiding this comment.
We have some constant to have the same accessibility sizes for all components (ComponentSnapshotTestConstants). I think you can also put this value inside your configuration
| slider.widthAnchor.constraint(equalToConstant: 200) | ||
| ]) | ||
| switch value { | ||
| case .medium: slider.setValue(0.5) |
There was a problem hiding this comment.
Because on the futur you will have the SwiftUI version, you can put the value (0.5, 0, 1) on your configuration ? Same for the testName.
You can check this configuration if you want: ProgressBarConfigurationSnapshotTests
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
| enum ComponentSnapshotTestMode: String { | |||
| enum ComponentSnapshotTestMode: String, CaseIterable { | |||
There was a problem hiding this comment.
Instead of CaseIterable, we manage the modes of the snapshot on a Constants:
- ComponentSnapshotTestConstants.Modes.all if you want to test all values
- ComponentSnapshotTestConstants.Modes.def if you want to test only the default value
…e (UISlider does indeed trigger a newValue even if the old one is equal to the new one)
… traitCollectionDidChange + added comments on functions using CGLayers like applyShadow
LouisBorleeAdevinta
force-pushed
the
204-component-slider-develop
branch
from
3d843bf
to
82586e6
Compare
LouisBorleeAdevinta
added
Component
LouisBorleeAdevinta
force-pushed
the
204-component-slider
branch
from
84cbbc2
to
21c1f51
Compare
|
The code seems good to me ! For the demo, I don't know why but there is no spacing between checkbox. Also, when I a add a steps, sometime I have this kind of value: |
|
About the checkbox spacing, it's just a stackview in which I didn't set spacing value, let me add that real quick :) About the floating values, it's the thing with floating numbers https://stackoverflow.com/questions/588004/is-floating-point-math-broken |
From branch 204-component-slider-develop to 204-component-slider