[CheckboxGroup#864] Fix disable checkbox group issue #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aycil-alican
changed the title
[RadioButton#853] Fix size of radio button
…small [Slider#1977] Updated Slider handle size from 24x24 to 32x32
| public override var isEnabled: Bool { | ||
| didSet{ | ||
| guard isEnabled != oldValue else { return } | ||
| if isEnabled { |
There was a problem hiding this comment.
I'm not sure of the logic here. Why can't all the checkboxes be set to enabled as in the disabled states?
If someone enables the whole component, shouldn't it override the status of each single component?
self.checkboxes.forEach { $0.isEnabled == isEnabled }
There was a problem hiding this comment.
ex; Checkbox group has 3 item and first item is disable then consumer wants to disable all and enable all in this case first item will be enable but it should be disable
michael-zimmermann
approved these changes
Apr 10, 2024
# Conflicts: # core/Sources/Components/Checkbox/View/SwiftUI/CheckboxGroupView.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed disable issue checkbox group.