Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Dark Shell Implementation using Aero Glass #408

Merged
merged 32 commits into from
Jan 10, 2014
Merged

Dark Shell Implementation using Aero Glass #408

merged 32 commits into from
Jan 10, 2014

Conversation

JeffryBooher
Copy link
Contributor

This started as an innovation week project to fix some of the issues with the Dark Shell by using the Desktop Window Manager to extend the client area the full size of the window.

This fixes a number of non-client area drawing since the system is no longer drawing the non-client area at all but front and center is the fix that extends the window frame onto secondary monitors.

The following issues are fixed with this:

adobe/brackets#5323
adobe/brackets#6185
adobe/brackets#5727 (NOTE: I was UTR on XP)
adobe/brackets#5480 (NOTE: This still occurs on XP but no longer on Vista, 7 and 8)
adobe/brackets#5288 (NOTE: I was UTR on XP)
adobe/brackets#5243 (NOTE: I was UTR on XP)

The issues marked UTR on XP just means that I did nothing to fix this expressly for XP -- Likely reasons why:

  • The problem is intermittent and my tests didn't reveal a reproducible case
  • The problem occurs when system settings are changed which are affect how the system wants Brackets to draw itself like Large Fonts or Thicker borders, etc...
  • The problem does not happen on an XP VM on a Mac
  • Or, hopefully, fixed with the other changes to make Dark Aero Glass work

For those issues we just need to record that in the bug notes so that the filer can test and let us know if it's truly fixed or not so we can move to the next level of trying to better understand why or convince Jonathon to drop support for XP.

Special thanks to @bchintx for helping implement the DLL wrapper for the Windows Desktop Window Manager and with Testing.

@ghost ghost assigned bchintx Jan 7, 2014
@bchintx
Copy link
Contributor

bchintx commented Jan 9, 2014

Done with code review. The changes look fine.

I've also reviewed the above-listed bugs on both my Win7 and WinXP (VM) and all issues appear to be fixed:
5323 - no border bleed on 2nd monitor in Win7. I don't have a native WinXP machine to confirm the same there.
5243 - I'm not seeing a problem on Win7
5288 - I was able to reproduce this prior to @JeffryBooher's last commit. However, it's fixed now.
5480 - not seeing the tooltip with the latest build
5727 and 6185 - icon fits maximized caption bar in both XP and Win7

Ready to merge pending confirmation from @peterflynn who's also testing on a native WinXP machine.

@JeffryBooher
Copy link
Contributor Author

@bchintx @peterflynn Just to be clear -- the border bleed onto a secondary monitor is not fixed for Windows XP. The solution was to use Aero Glass which is not available on XP.

@bchintx
Copy link
Contributor

bchintx commented Jan 10, 2014

Looks good. Merging...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants