-
Notifications
You must be signed in to change notification settings - Fork 617
Dark Shell Implementation using Aero Glass #408
Conversation
Done with code review. The changes look fine. I've also reviewed the above-listed bugs on both my Win7 and WinXP (VM) and all issues appear to be fixed: Ready to merge pending confirmation from @peterflynn who's also testing on a native WinXP machine. |
@bchintx @peterflynn Just to be clear -- the border bleed onto a secondary monitor is not fixed for Windows XP. The solution was to use Aero Glass which is not available on XP. |
Looks good. Merging... |
Dark Shell Implementation using Aero Glass
Dark Shell Implementation using Aero Glass
This started as an innovation week project to fix some of the issues with the Dark Shell by using the Desktop Window Manager to extend the client area the full size of the window.
This fixes a number of non-client area drawing since the system is no longer drawing the non-client area at all but front and center is the fix that extends the window frame onto secondary monitors.
The following issues are fixed with this:
adobe/brackets#5323
adobe/brackets#6185
adobe/brackets#5727 (NOTE: I was UTR on XP)
adobe/brackets#5480 (NOTE: This still occurs on XP but no longer on Vista, 7 and 8)
adobe/brackets#5288 (NOTE: I was UTR on XP)
adobe/brackets#5243 (NOTE: I was UTR on XP)
The issues marked UTR on XP just means that I did nothing to fix this expressly for XP -- Likely reasons why:
For those issues we just need to record that in the bug notes so that the filer can test and let us know if it's truly fixed or not so we can move to the next level of trying to better understand why or convince Jonathon to drop support for XP.
Special thanks to @bchintx for helping implement the DLL wrapper for the Windows Desktop Window Manager and with Testing.