Auto Update Framework #634

mbhavi · 2018-03-27T16:05:56Z

This PR includes changes for Auto Update of Brackets.
The changes are with respect to:

Windows implementation
Mac implementation

ping @swmitra @nethip for review

This reverts commit 09199fc.

… config flie HAS to be named CustomAction.config else Wix ignores it

Also modified update.sh to be an executable(using chmod), so that it can be run as a script

nethip · 2018-03-28T05:46:26Z

appshell/appshell_extensions.cpp

@@ -507,7 +508,35 @@ class ProcessMessageDelegate : public ClientHandler::ProcessMessageDelegate {
                error = CopyFile(src, dest);
                // No additional response args for this function
            }
-        } else if (message_name == "GetDroppedFiles") {
+        } else if (message_name == "SetUpdateParamsAndRunUpdate") {
+			// Parameters:


nit: Please fix the indentation.

Addressed in ad0d490

…ts-shell into mbhavi-miglani/autoUpdate

…into mbhavi-miglani/autoUpdate

This should fix the issue where the dmg windwow looks wrong on mounting it

nethip · 2018-04-05T10:58:58Z

appshell/appshell_extensions.cpp

@@ -507,7 +508,35 @@ class ProcessMessageDelegate : public ClientHandler::ProcessMessageDelegate {
                error = CopyFile(src, dest);
                // No additional response args for this function
            }
-        } else if (message_name == "GetDroppedFiles") {
+        } else if (message_name == "SetUpdateParamsAndRunUpdate") {


Where are you calling this method from in your extension?

It is called from initiateUpdateProcess() in main.js file, from the extension.

@mbhavi Can you help me point to the exact location in your PR adobe/brackets#14177. You could click on the line where this is getting called and copy paste the URL from the browser, here.

Here is where it is called in main.js on extension side : https://github.com/adobe/brackets/pull/14177/files#diff-7c95ea028e4f63308de3fda22211850cR392

The mapping for this function can be located here : https://github.com/adobe/brackets-shell/pull/634/files#diff-bbbf811f33a27b114763e0255590293fR656

Thanks @mbhavi Got it!

nethip · 2018-04-05T11:05:43Z

appshell/update_mac.mm

+        NSArray* pArgs = [NSArray arrayWithObjects:@"detach", mountPoint,  @"-force", nil];
+
+        int retval = RunScript(hdiPath, pArgs, true);
+        while (retval != 1) {


When do you exit from the loop?

The loop is exited when any prior dmgs mounted on the mount point /Volumes/BracketsAutoUpdate are unmounted. Before I mount the new dmg, I unmount any dmgs mounted already on the same mountpoint.

dmg creation

… miglani/autoUpdate

Merging installer changes required for autoupdate to function

…ts-shell into miglani/autoUpdate

mbhavi · 2018-04-09T05:29:26Z

@nethip , I have addressed and committed all the required changes. Also, I have replied to all the comments.
The PR is ready for review again.

lokwani · 2018-04-09T08:07:44Z

Installer changes LGTM

nethip · 2018-04-09T10:54:12Z

Gruntfile.js

+                        "flatten"   : true,
+                        "expand"    : true,
+                        "src"       : [
+                            "installer/win/LaunchBrackets/LaunchBrackets/bin/Release/LaunchBrackets.CA.dll",


Where is the source for these DLLs?

Ignore this comment.

nethip · 2018-04-09T10:55:47Z

installer/win/Brackets.wxs

+             Sequence="execute"
+             Value="[%PATH]" />
+
+        <Binary Id="InstallLocationChecker.dll" SourceFile="BracketsConfigurator.CA.dll" />


The source for this and how these DLLs are built?

Found them below. Please ignore the comment.

nethip · 2018-04-09T10:57:27Z

installer/win/BracketsConfigurator/BracketsConfigurator/BracketsConfigurator.cs

@@ -0,0 +1,67 @@
+using System;


Copyright missing?

@gavankar , please address this

@nethip we have never had a copyright in the installer files so far(installer/win/Brackets.wxs), should we be adding one now? This file creates a customhook dll in the installer

Yes please go ahead.

@gavankar , please address this

@mbhavi, Please accept the following pull request which has this fix -
mbhavi#2

@gavankar , I have merged your PR. @nethip , please find the review comments addressed here, as part of this merge.

nethip · 2018-04-09T10:57:46Z

installer/win/LaunchBrackets/LaunchBrackets/LaunchBrackets.cs

@@ -0,0 +1,30 @@
+using System;


Copyright missing?

@gavankar , please address this.

@nethip we have never had a copyright in the installer files so far(installer/win/Brackets.wxs), should we be adding one now? This file creates a customhook dll in the installer

mbhavi · 2018-04-10T09:30:05Z

@nethip , addressed review comments and making auto update no-op on Linux, in 3f6d92d. The review can be resumed now.

Adding a license to the top of the Windows customaction files

nethip · 2018-04-10T10:05:04Z

@mbhavi @gavankar Are the custom action DLLs like BracketsExecutor part of this PR? Can you create a wiki post merging this PR as to what the steps to generate the DLLs.

Also @mbhavi post merging this PR, can you raise a PR with unit tests for the auto update process?

gavankar · 2018-04-10T10:56:33Z

@nethip, the steps to create BracketsConfigurator.CA.dll and LaunchBrackets.CA.dll have been added to the "build-win" grunt task, these steps are completely automated through grunt. Do we still require a wiki about the steps for generating the dlls?

nethip · 2018-04-10T11:03:29Z

@gavankar Thanks for pointing out! Pretty neat! No need of adding a wiki for this.

This PR looks good. LGTM

@mbhavi Thanks for your efforts in making this happen and being patient in addressing the review comments 😄 . Really appreciate it. And great job 💯 Please address the review comments in Brackets as well. Thanks!

I would merge this after @ayushrathi15 confirms the results from sanity testing.

… miglani/autoUpdate

harshit0405 and others added 11 commits December 1, 2017 22:47

XLST Change

09199fc

Revert "XLST Change"

f854334

This reverts commit 09199fc.

Updating checkbox to accept CLI Inputs

a2716f1

Auto updater changes

9995169

Renamed custom action projects, added build process for DLLs

16ae66c

Renaming config files to match required convention for Wix. Note: The…

2241c1a

… config flie HAS to be named CustomAction.config else Wix ignores it

Updating error log in custom action

47b00e9

Adding back Exit Dialog UI

39e24ab

AutoUpdate Framework : Initial Changes

1d4be2f

Adding update script for MAC

bf68a58

Updating buildinstaller.sh to add update.sh to the installer

98859d0

Also modified update.sh to be an executable(using chmod), so that it can be run as a script

nethip reviewed Mar 28, 2018

View reviewed changes

mbhavi and others added 5 commits March 28, 2018 12:47

Fixing incorrect invocation

95d2c02

Merge branch 'miglani/autoUpdate' of https://github.com/mbhavi/bracke…

c885d5d

…ts-shell into mbhavi-miglani/autoUpdate

Merge branch 'master' of https://github.com/harshit0405/brackets-shell …

b50bfb4

…into mbhavi-miglani/autoUpdate

Modifying DropDMG layout to include .update.sh

9d44487

This should fix the issue where the dmg windwow looks wrong on mounting it

Error handling, and code cleanup changes

a88abd7

nethip reviewed Apr 5, 2018

View reviewed changes

gavankar and others added 7 commits April 5, 2018 18:18

Explicitly setting execute permission on update.sh as part of the

de725a8

dmg creation

Fixing a typo in the dmg creation script

3174b12

Error handling, and code cleanup

09aaaa3

Merge branch 'master' of https://github.com/adobe/brackets-shell into…

0eb6ec1

… miglani/autoUpdate

Merge pull request #1 from gavankar/mbhavi-miglani/autoUpdate

1be99a5

Merging installer changes required for autoupdate to function

Fixing indentation

ad0d490

Merge branch 'miglani/autoUpdate' of https://github.com/mbhavi/bracke…

f5cc9ac

…ts-shell into miglani/autoUpdate

nethip reviewed Apr 9, 2018

View reviewed changes

mbhavi and others added 2 commits April 10, 2018 13:44

Addressing review comments, making autoUpdate no-op on Linux

3f6d92d

Adding a license to the top of the Windows customaction files

a67ec0b

Merge pull request #2 from gavankar/mbhavi-miglani/autoUpdate

c3ff012

Adding a license to the top of the Windows customaction files

mbhavi changed the title ~~[WIP] : Auto Update Framework~~ Auto Update Framework Apr 17, 2018

Merge branch 'master' of https://github.com/adobe/brackets-shell into…

1111562

… miglani/autoUpdate

nethip merged commit cb6ab77 into adobe:master Apr 18, 2018

core-ai-bot mentioned this pull request Aug 17, 2021

[CLOSED] Auto Update Framework brackets-archive/brackets-shell#415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto Update Framework #634

Auto Update Framework #634

mbhavi commented Mar 27, 2018 •

edited

Loading

nethip Mar 28, 2018

mbhavi Apr 9, 2018

nethip Apr 5, 2018

mbhavi Apr 5, 2018

nethip Apr 6, 2018

mbhavi Apr 6, 2018

nethip Apr 6, 2018

nethip Apr 5, 2018

mbhavi Apr 5, 2018

mbhavi commented Apr 9, 2018

lokwani commented Apr 9, 2018 •

edited

Loading

nethip Apr 9, 2018

nethip Apr 9, 2018

nethip Apr 9, 2018

nethip Apr 9, 2018

nethip Apr 9, 2018

mbhavi Apr 9, 2018

gavankar Apr 9, 2018 •

edited

Loading

nethip Apr 9, 2018

mbhavi Apr 10, 2018

gavankar Apr 10, 2018

mbhavi Apr 10, 2018

nethip Apr 9, 2018

mbhavi Apr 9, 2018

gavankar Apr 9, 2018 •

edited

Loading

mbhavi commented Apr 10, 2018 •

edited

Loading

nethip commented Apr 10, 2018

gavankar commented Apr 10, 2018

nethip commented Apr 10, 2018

Auto Update Framework #634

Auto Update Framework #634

Conversation

mbhavi commented Mar 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbhavi commented Apr 9, 2018

lokwani commented Apr 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavankar Apr 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavankar Apr 9, 2018 • edited Loading

Choose a reason for hiding this comment

mbhavi commented Apr 10, 2018 • edited Loading

nethip commented Apr 10, 2018

gavankar commented Apr 10, 2018

nethip commented Apr 10, 2018

mbhavi commented Mar 27, 2018 •

edited

Loading

lokwani commented Apr 9, 2018 •

edited

Loading

gavankar Apr 9, 2018 •

edited

Loading

gavankar Apr 9, 2018 •

edited

Loading

mbhavi commented Apr 10, 2018 •

edited

Loading