Merge pull request #2397 from adobe/nj/cmv3-scrollIntoView

[cmv3] Ensure inline widgets are scrolled to be fully visible when opened, and ...
adobe · Dec 19, 2012 · 223ebf4 · 223ebf4
2 parents f028229 + 32afc6f
commit 223ebf4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/src/editor/Editor.js b/src/editor/Editor.js
@@ -959,8 +959,17 @@ define(function (require, exports, module) {
         var node = inlineWidget.htmlContent,
             oldHeight = (node && $(node).height()) || 0;
 
-        // TODO: handle ensureVisible
         $(node).height(height);
+        if (ensureVisible) {
+            var offset = $(node).offset(),
+                lineSpaceOffset = $(this._getLineSpaceElement()).offset();
+            this._codeMirror.scrollIntoView({
+                left: offset.left - lineSpaceOffset.left,
+                top: offset.top - lineSpaceOffset.top,
+                right: offset.left - lineSpaceOffset.left, // don't try to make the right edge visible
+                bottom: offset.top + height - lineSpaceOffset.top
+            });
+        }
 
         // update position for all following inline editors
         if (oldHeight !== height) {

diff --git a/src/editor/MultiRangeInlineEditor.js b/src/editor/MultiRangeInlineEditor.js
@@ -425,7 +425,7 @@ define(function (require, exports, module) {
     MultiRangeInlineEditor.prototype._ensureCursorVisible = function () {
         if ($.contains(this.editors[0].getRootElement(), window.document.activeElement)) {
             var cursorCoords = this.editors[0]._codeMirror.cursorCoords(),
-                lineSpaceOffset = $(this.editors[0]._getLineSpaceElement()).offset(),
+                inlineLineSpaceOffset = $(this.editors[0]._getLineSpaceElement()).offset(),
                 rangeListOffset = this.$relatedContainer.offset();
             // If we're off the left-hand side, we just want to scroll it into view normally. But
             // if we're underneath the range list on the right, we want to ask the host editor to 
@@ -436,16 +436,14 @@ define(function (require, exports, module) {
             }
 
             // Vertically, we want to set the scroll position relative to the overall host editor, not
-            // the lineSpace of the widget itself. Also, we can't use the lineSpace here, because its top
-            // position just corresponds to whatever CodeMirror happens to have rendered at the top. So
-            // we need to figure out our position relative to the top of the virtual scroll area, which is
-            // the top of the actual scroller minus the scroll position.
-            var scrollerTop = $(this.hostEditor.getScrollerElement()).offset().top - this.hostEditor.getScrollPos().y;
-            // TODO: [cmv3] scrollIntoView isn't implemented yet
-//            this.hostEditor._codeMirror.scrollIntoView(cursorCoords.left - lineSpaceOffset.left,
-//                                                       cursorCoords.top - scrollerTop,
-//                                                       cursorCoords.left - lineSpaceOffset.left,
-//                                                       cursorCoords.bottom - scrollerTop);
+            // the lineSpace of the widget itself.
+            var hostLineSpaceTop = $(this.hostEditor._getLineSpaceElement()).offset().top;
+            this.hostEditor._codeMirror.scrollIntoView({
+                left: cursorCoords.left - inlineLineSpaceOffset.left,
+                top: cursorCoords.top - hostLineSpaceTop,
+                right: cursorCoords.left - inlineLineSpaceOffset.left,
+                bottom: cursorCoords.bottom - hostLineSpaceTop
+            });
         }
     };