This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
[cmv3] Ensure inline widgets are scrolled to be fully visible when opened, and ... #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd ensure cursor within inline widget remains visible on selection change
ghost
assigned
| left: cursorCoords.left - inlineLineSpaceOffset.left, | ||
| top: cursorCoords.top - hostLineSpaceTop, | ||
| right: cursorCoords.left - inlineLineSpaceOffset.left, | ||
| bottom: cursorCoords.bottom - hostLineSpaceTop |
There was a problem hiding this comment.
Note that we can use the hostEditor's lineSpace here now because the new scrolling mechanism in v3 still has the lineSpace always be the full height of the virtual document (instead of just a small window around the viewport as in our original version).
gruehle
added a commit
that referenced
this pull request
Dec 19, 2012
[cmv3] Ensure inline widgets are scrolled to be fully visible when opened, and ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ensure cursor within inline widget remains visible on selection change
@gruehle
Note that this relies on a new feature of
scrollIntoView(), the ability to scroll a specific rectangle to be visible, which Marijn just added upstream and is already merged into our upstream-master branch of CodeMirror.