Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Cannot dismiss Find modalbar with keyboard after using Previous or Next buttons #5262

Closed
redmunds opened this issue Sep 19, 2013 · 9 comments
Assignees
Milestone

Comments

@redmunds
Copy link
Contributor

  1. Ctrl-F to find some text in page
  2. Click "Next" or "Previous" button to move to another instance
  3. Press Enter or Esc

Result:
Nothing happens

Expected
Find modal bar is dismissed

Seems to be a focus issue -- click back in search field the keyboard works as expected.

@redmunds
Copy link
Contributor Author

Nominating for Sprint 32. @rajeshsegu Can you take this one?

@rajeshsegu
Copy link

@redmunds I can definitely take this. Thanks for finding the culprit. ;)

marcelgerber pushed a commit to marcelgerber/brackets that referenced this issue Sep 23, 2013
The dialog can be dismissed, but it's not as nice as it should.
But it does it's job because you can't do anything else than typing in the input field after clicking a navigator button.
@peterflynn
Copy link
Member

@rajeshsegu Looks like @SAplayer just posted a potential fix. Can you take a look at add comments in #5297?

@peterflynn
Copy link
Member

Reviewed. Assigned to @redmunds as the core-team owner since it's nominated for Sprint 32.

@ghost ghost assigned redmunds Sep 23, 2013
@rajeshsegu
Copy link

@SAplayer I think the code needs a minor change, please fix it. Thanks.

@peterflynn @redmunds Otherwise, the fix looks pretty good.

@redmunds
Copy link
Contributor Author

@rajeshsegu We decided not to take pull #5297, and you said that you would take this one over. We'd like to get this fix in Sprint 33 which ends 10/24. Let me know if you won't be able to work on it by then.

@redmunds
Copy link
Contributor Author

@rajeshsegu FYI, I submitted a fix for this.

@JeffryBooher
Copy link
Contributor

FBNC @redmunds? Judge, Jury and Executioner... 🔨

@redmunds
Copy link
Contributor Author

Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants