[CLOSED] Cannot dismiss Find modalbar with keyboard after using Previous or Next buttons

[core-ai-bot]

Issue by redmunds
Thursday Sep 19, 2013 at 14:35 GMT
Originally opened as adobe/brackets#5262

---

1. Ctrl-F to find some text in page
2. Click "Next" or "Previous" button to move to another instance
3. Press Enter or Esc

Result:
Nothing happens

Expected
Find modal bar is dismissed

Seems to be a focus issue -- click back in search field the keyboard works as expected.

[core-ai-bot]

Comment by redmunds
Thursday Sep 19, 2013 at 15:38 GMT

---

Nominating for Sprint 32.@rajeshsegu Can you take this one?

[core-ai-bot]

Comment by rajeshsegu
Friday Sep 20, 2013 at 19:19 GMT

---

@redmunds I can definitely take this. Thanks for finding the culprit. ;)

[core-ai-bot]

Comment by peterflynn
Monday Sep 23, 2013 at 18:48 GMT

---

@rajeshsegu Looks like@SAPlayer just posted a potential fix. Can you take a look at add comments in #5297?

[core-ai-bot]

Comment by peterflynn
Monday Sep 23, 2013 at 18:49 GMT

---

Reviewed. Assigned to@redmunds as the core-team owner since it's nominated for Sprint 32.

[core-ai-bot]

Comment by rajeshsegu
Monday Sep 23, 2013 at 19:13 GMT

---

@SAPlayer I think the code needs a minor change, please fix it. Thanks.

@peterflynn@redmunds Otherwise, the fix looks pretty good.

[core-ai-bot]

Comment by redmunds
Thursday Oct 10, 2013 at 17:33 GMT

---

@rajeshsegu We decided not to take pull #5297, and you said that you would take this one over. We'd like to get this fix in Sprint 33 which ends 10/24. Let me know if you won't be able to work on it by then.

[core-ai-bot]

Comment by redmunds
Wednesday Oct 23, 2013 at 14:46 GMT

---

@rajeshsegu FYI, I submitted a fix for this.

[core-ai-bot]

Comment by JeffryBooher
Wednesday Oct 23, 2013 at 18:33 GMT

---

FBNC@redmunds? Judge, Jury and Executioner... 🔨

[core-ai-bot]

Comment by redmunds
Wednesday Oct 23, 2013 at 19:02 GMT

---

Closing.