This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Merge cmv3 into master #2853
Merged
Merge cmv3 into master #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed events on Editor to use new CodeMirror event mechanism instead of setOption() - changed getScrollerElement() to getRootElement() for managing height - changed delCharLeft()/delCharRight() to delCharBefore()/delCharAfter() - changed various CodeMirror style classes whose names have changed - commented out some unimplemented methods - updated CodeMirror SHA
- update inline editors to use new addLineWidget() API - use markText() for line hiding - refresh host editor after adding an inline widget so CodeMirror updates its line heights properly - make rule list appear in front of code in inline widget
…d on the upgrade guide in the v3 docs.
… relative to font size.
[cmv3] do not hide lines when the range is zero
…ion > 3.0beta1 or > 2.31.
* Don't try to hide any lines if the range to hide is empty. * Set inclusiveLeft/inclusiveRight when marking text to be hidden so the first/last lines are included. * If focus is in an inline widget before a refresh, restore focus afterward. * Call _removeInlineWidgetInternal() when we remove a widget since we no longer get called back in this case. * Fix up unit test hidden line verification to work with new v3 API. Note that there are still three failing unit tests in InlineEditorProviders-test. Two of them are related to inline widget sizing, which will be addressed in a future user story. The third will be fixed by a bugfix that we're submitting upstream: https://github.com/njx/CodeMirror/compare/widget-focus
[cmv3] Inline editor bugfixes
…nd ensure cursor within inline widget remains visible on selection change
[cmv3] Ensure inline widgets are scrolled to be fully visible when opened, and ...
Properly clip rule list to status bar
For #2780, ensure that the cursor doesn't interfere with mouse events
Specify edit origin for color editor widgets in order to batch undos
Update HTML code hints unit test since we're now filtering already used attributes.
…n type but actually either inside an attribute value or after an empty attribute value. Also add three more extension unit tests to verify the new code.
For #2806, refresh child editor on timeout after redraw event
…to nj/merge-find-stuff
Fix attribute hint issue #2804
…emporary cherry-pick of a fix from upstream and avoids other fixes we don't want yet.
Fix dropdown closing
…g the editor. Addresses some cases in #2782.
Adjust rules on when to refresh Editor, to fix bugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gruehle
DON'T TASE ME BRO