Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition output partialy missing if type is not object #228

Closed
alainlecluse opened this issue Jun 1, 2020 · 1 comment
Closed

Definition output partialy missing if type is not object #228

alainlecluse opened this issue Jun 1, 2020 · 1 comment

Comments

@alainlecluse
Copy link
Contributor

What did you do

We use multiple schemas. and one base schema for shared definitions. mainly containing simple types.

What did you expect to happen

expected

{
  "$schema": "http://json-schema.org/draft-07/schema",
  "$id": "/BaseTypes",
  "title": "Base Types",
  "definitions": {
    "changeOfValue": {
      "type": "number",
      "minimum": 0,
      "title": "Change Of Value offset",
      "description": "Offset between old and new value needed before the new value is sent"
    }
}

to output something like

## changeOfValue

Offset between old and new value needed before the new value is sent


`changeOfValue`

-   is optional
-   Type: `number` ([Change Of Value offset](base-types-definitions-change-of-value-offset.md))
-   cannot be null
-   defined in: [Ping](base-types-definitions-change-of-value-offset.md "/DataCollector/PingModule#/properties/properties/properties/defaults/properties/changeOfValue")

### changeOfValue Type

`number` ([Change Of Value offset](base-types-definitions-change-of-value-offset.md))

### changeOfValue Constraints

**minimum**: the value of this number must greater than or equal to: `0`

What happened

got output

# Base Types Definitions

## Definitions group changeOfValue

Reference this group by using

` ` `json
{"$ref":"/BaseTypes#/definitions/changeOfValue"}
` ` `

| Property | Type | Required | Nullable | Defined by |
| :------- | ---- | -------- | -------- | :--------- |

It goes oke if the type within the definition is an Object

alainlecluse added a commit to alainlecluse/jsonschema2md that referenced this issue Jun 9, 2020
trieloff pushed a commit that referenced this issue Jun 22, 2020
## [4.1.4](v4.1.3...v4.1.4) (2020-06-22)

### Bug Fixes

* definition object defintions based on proplist structure ([2fb9fc5](2fb9fc5)), closes [#228](#228)
@alainlecluse
Copy link
Contributor Author

@trieloff I think this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants