Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Definition object, definitions based on the property list structure #229

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

alainlecluse
Copy link
Contributor

#228
fix: Definition object, definitions based on the property list structure

@trieloff
Copy link
Collaborator

trieloff commented Jun 9, 2020

What's the reason for removing the table?

@alainlecluse
Copy link
Contributor Author

What I noticed was that the definitions only worked for objects.
So if a definition element is not an object, the group table was always empty, and no relevant information was provided for the definition.

My initial start was to make the group table and property list conditional based on the type. And add a maketypefact section a link for more information.

Before committing that solution, I've concluded that it deviated too much from how the property section is constructed.
It is resulting in the combination of the reference block and the parts from a normale property.

@trieloff
Copy link
Collaborator

@alainlecluse can you confirm that you signed the CLA?

@alainlecluse
Copy link
Contributor Author

@trieloff Yes, I did.
I do not know why it keeps saying I did not

@trieloff trieloff merged commit a0ee4c9 into adobe:master Jun 22, 2020
@trieloff
Copy link
Collaborator

🎉 This PR is included in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants