Drop support for Ember < 4.8 and node < 18 (#1655)

* v5.1.0...v5.6.0

* Remove analytics mocking

Analytics were removed from ember-cli, so we don't need to mock them (and can't because the `mock-analytics` module was also deleted!

Note that we're leaving the `this.analytics` references in `electron.js` to maintain compatibility with `ember-cli` < 5.4

* Simplify end-to-end test matrix

There's no longer a reason to test against both npm and yarn, so simplify!

* Fix test command

Enable the `--test-port` option. It's a good one to have regardless, but also logic inside `ember-cli`'s `test` command blows up if the option isn't present.

* Remove unused method

This used to be an override of a method in the base class, but that method is long gone...

.ember-cli

@@ -1,12 +1,4 @@
 {
-  /**
-    Ember CLI sends analytics information by default. The data is completely
-    anonymous, but there are times when you might want to disable this behavior.
-
-    Setting `disableAnalytics` to true will prevent any data from being sent.
-  */
-  "disableAnalytics": false,
-
   /**
     Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
     rather than JavaScript by default, when a TypeScript version of a given blueprint is available.

.github/workflows/main.yml

@@ -43,24 +43,21 @@ jobs:
 
   # runs slow end-to-end tests, parallelizing yarn and npm cases
   test-end-to-end:
-    name: End-to-end tests (${{ matrix.os }}/${{ matrix.package-manager }})
+    name: End-to-end tests (${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         os: [macos-latest, ubuntu-latest, windows-latest]
-        package-manager: ['npm', 'yarn']
 
     steps:
       - uses: actions/checkout@v2
       - uses: volta-cli/action@v1
       - run: yarn install --frozen-lockfile --network-timeout 100000
 
-      - name: 'End-to-end Tests (${{ matrix.package-manager }})'
+      - name: 'End-to-end Tests'
         uses: GabrielBB/xvfb-action@v1
         with:
           run: yarn test-slow
-        env:
-          END_TO_END_TESTS: '${{ matrix.package-manager }}'
 
   automerge:
     needs: [lint, test, test-end-to-end]

.gitignore

@@ -1,5 +1,6 @@
 # compiled output
 /dist/
+/declarations/
 
 # dependencies
 /node_modules/

CONTRIBUTING.md

@@ -13,13 +13,13 @@
 
 ## Running tests
 
-* `ember test` – Runs the test suite on the current Ember version
-* `ember test --server` – Runs the test suite in "watch mode"
-* `ember try:each` – Runs the test suite against multiple Ember versions
+* `yarn test` – Runs the test suite on the current Ember version
+* `yarn test:ember --server` – Runs the test suite in "watch mode"
+* `yarn test:ember-compatibility` – Runs the test suite against multiple Ember versions
 
 ## Running the dummy application
 
-* `ember serve`
+* `yarn start`
 * Visit the dummy application at [http://localhost:4200](http://localhost:4200).
 
 For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).

README.md

@@ -11,9 +11,9 @@ An Ember addon to turn Ember apps into cross-platform desktop applications, taki
 
 ## Compatibility
 
-* Ember.js v4.4 or above
-* Ember CLI v4.4 or above
-* Node.js v16 or above
+* Ember.js v4.8 or above
+* Ember CLI v4.8 or above
+* Node.js v18 or above
 
 ## Documentation
 

config/ember-cli-update.json

@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "5.1.0",
+      "version": "5.6.0",
       "blueprints": [
         {
           "name": "addon",

lib/commands/test.js

@@ -10,18 +10,6 @@ module.exports = TestCommand.extend({
 
   availableOptions: buildAvailableOptions(),
 
-  rmTmp() {
-    if (process.platform === 'win32') {
-      // There is some kind of race condition where we intermittently get EBUSY
-      // deleting the temp directory on windows, which causes the test to fail.
-      // Unfortunately adding logging to try to track it down makes it go away,
-      // so let's just delay for a bit as a dirty workaround.
-      require('child_process').execSync('ping 127.0.0.1 -n 2 > nul');
-    }
-
-    return this._super(...arguments);
-  },
-
   async run(commandOptions) {
     let _super = this._super;
     await prepareRunCommand(this.project);
@@ -38,6 +26,7 @@ function buildAvailableOptions() {
     'environment',
     'config-file',
     'server',
+    'test-port',
     'filter',
     'module',
     'watcher',