Drop support for Ember < 4.8 and node < 18 #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendemboski
added
dependencies
bendemboski
force-pushed
the
ember-5-6
branch
2 times, most recently
from
eac1690
to
9313ff6
Compare
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [macos-latest, ubuntu-latest, windows-latest] | ||
| package-manager: ['npm', 'yarn'] |
There was a problem hiding this comment.
Do we not want to check multiple package managers anymore?
There was a problem hiding this comment.
I don't really think we need to. Since we don't run the blueprint automatically, I think the actual package install is just a regular package install. So I can't think of anything we'd be testing by testing multiple package managers other than the package managers themselves? Maybe I'm missing/forgetting something?
bendemboski
force-pushed
the
ember-5-6
branch
from
583e937
to
a18fef7
Compare
RobbieTheWagner
changed the title
RobbieTheWagner
approved these changes
Feb 6, 2024
Analytics were removed from ember-cli, so we don't need to mock them (and can't because the `mock-analytics` module was also deleted! Note that we're leaving the `this.analytics` references in `electron.js` to maintain compatibility with `ember-cli` < 5.4
There's no longer a reason to test against both npm and yarn, so simplify!
Enable the `--test-port` option. It's a good one to have regardless, but also logic inside `ember-cli`'s `test` command blows up if the option isn't present.
This used to be an override of a method in the base class, but that method is long gone...
bendemboski
force-pushed
the
ember-5-6
branch
from
a18fef7
to
bc98d8e
Compare
RobbieTheWagner
removed
the
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps minimum Ember to 4.8 and minimum node to 18