Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JDK_VENDOR in playlists #115

Closed
smlambert opened this issue Nov 12, 2020 · 7 comments
Closed

Add support for JDK_VENDOR in playlists #115

smlambert opened this issue Nov 12, 2020 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@smlambert
Copy link
Contributor

There may be several use cases where we want to differentiate by JDK_VENDOR (which is over and beyond differentiating by JDK_IMPL).

We have currently blended the meaning of JDK_IMPL with vendor (hotspot, sap, corretto, dragonwell are all hotspot VM impl based, but rightly we should categorize them as JDK_VENDOR (adopt, sap, amazon, alibaba) or whatever value is returned by a query of java.vendor. (related: adoptium/temurin-build#465)

As there are tests that may be vendor specific (many build/packaging tests for example).

@adamfarley
Copy link
Contributor

Looking into this, so we can create the adopt-only test needed for adoptium/temurin-build#2226

@smlambert
Copy link
Contributor Author

This may end up to be a documentation effort, as JDK_IMPL is currently nearly equivalent to JDK_VENDOR and we may not have a need for an explicit VM_IMPL differentiator.

Will discuss with @renfeiw and @llxia this week.

@smlambert
Copy link
Contributor Author

Some discussion on the topic:
We currently populate JDK_IMPL with value returned from java.vm.name. We will look at what is returned by a query to java.vm.vendor (from each of the known/accessible OpenJDK distributors) and possibly use a combination of java.vm.name and java.vm.vendor.

@smlambert
Copy link
Contributor Author

smlambert commented Jan 9, 2021

Table of Vendors and Expected System.properties values

Impl Vendor java.vendor=xxxx
Hotspot AdoptOpenJDK Hotspot AdoptOpenJDK
" Upstream/OpenJDK/RH Oracle Corporation
" Alibaba Dragonwell Alibaba
" Amazon Corretto Amazon.com Inc.
" SAP Sapmachine SAP SE
" Azul Zulu Azul Systems, Inc.
" Bellsoft Liberica BellSoft
OpenJ9 AdoptOpenJDK OpenJ9 AdoptOpenJDK
" IBM IBM

As verified through: Grinder_TKG 89 - Grinder_TKG 96

@renfeiw
Copy link
Contributor

renfeiw commented Jan 11, 2021

Table of Vendors and Expected System.properties values

Impl Vendor java.vendor=xxxx
Hotspot AdoptOpenJDK Hotspot AdoptOpenJDK
" Upstream/OpenJDK/RH Oracle Corporation
" Alibaba Dragonwell Alibaba
" Amazon Corretto Amazon.com Inc.
" SAP Sapmachine SAP SE
" Azul Zulu Azul Systems, Inc.
" Bellsoft Liberica BellSoft
OpenJ9 AdoptOpenJDK OpenJ9 AdoptOpenJDK
" IBM IBM
As verified through: Grinder_TKG 89 - Grinder_TKG 96

I am working on a PR to add JDK_VENDOR. This information is really helpful!

@smlambert
Copy link
Contributor Author

smlambert commented Jan 11, 2021

@renfeiw - take a look at smlambert:vendor branch, where I started... but still didn't add the playlist element and ability to add filtering.

@smlambert
Copy link
Contributor Author

Fixed by #142 - thanks @renfeiw !

@karianna karianna added this to the January 2021 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants