Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JDK_IMPL_BASE to distinguish implementation #2056

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Use JDK_IMPL_BASE to distinguish implementation #2056

merged 1 commit into from
Nov 18, 2020

Conversation

joeyleeeeeee97
Copy link
Contributor

Use base JDK implementation to trigger tests.
Issue: #2041

@smlambert smlambert requested a review from llxia November 16, 2020 23:51
@smlambert
Copy link
Contributor

Related: adoptium/TKG#115 - there is a consideration to introduce JDK_VENDOR so as to not convolute JDK_IMPL (which was originally intended to be VM implementation, which would ultimately get used in this template.

We need not delay this change, but rather revisit the template after a change for TKG 115 is in.

@smlambert smlambert added this to the November 2020 milestone Nov 16, 2020
@karianna
Copy link
Contributor

Related: AdoptOpenJDK/TKG#115 - there is a consideration to introduce JDK_VENDOR so as to not convolute JDK_IMPL (which was originally intended to be VM implementation, which would ultimately get used in this template.

We need not delay this change, but rather revisit the template after a change for TKG 115 is in.

Agreed I'd rather that we use Vendor - but we need to do a pretty major refactor across build, test, API and website for this

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented Nov 17, 2020

Tested in internal Test_Job_Auto_Gen_Sandbox (61 and 62) as the script needs Admin approval for running at Adopt Jenkins.

@llxia
Copy link
Contributor

llxia commented Nov 17, 2020

@ShelleyLambert I will leave it to you to merge because this script needs to be approved in Adopt Jenkins. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants