Add jdk vendor in TKG #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested in Grinder_TKG/1130，Grinder_TKG/1132 (randomly specified vendors in tests) |
- TKG will check if JDK_VENDOR matches vendor defined in playlist Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
smlambert
approved these changes
Jan 21, 2021
| } else if (vendorLC.contains("oracle")) { | ||
| return "oracle"; | ||
| } else { | ||
| System.out.println("Warning: cannot determine vendor, use System.getProperty('java.vendor')=" + vendor + " directly.\n"); |
There was a problem hiding this comment.
I like in particular how you handled this (versus my hard fail version), it means ones we may have missed can still proceed to use this.
|
This is an enhancement and we will merge it after the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: renfeiw renfeiw@ca.ibm.com