-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bisheng JDK_IMPL to hotspot #2589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we need to resolve the TODO in https://github.com/adoptium/temurin-build/blob/921ec1893c2611d5b7865d2b83be418ec3c5831e/test/functional/buildAndPackage/src/net/adoptium/test/VendorPropertiesTest.java#L55 in order to perform the smoke test checks properly but this should resolve the immediate problem :-)
Based on the comment above, is this PR addressing a particular smoke test failure? If so, will be good to reference it somewhere. If this PR is to resolve an immediate problem of smoke tests that should not target Bisheng, then possibly use vendor tag, |
Reference to the Slack discussion to give context to this PR: https://adoptium.slack.com/archives/C09NW3L2J/p1621579653024100 |
TLDR: This PR was to fix a problem where a smoke test job was run against a bisheng build, but would fail immediately because the detected JDK implementation (hotspot) didn't match the JDK_IMPL parameter (bisheng) passed from the build job. Details Smoke test error message:
Underlying cause: The test job template incorrectly identified bisheng as a discrete JDK implementation, as opposed to a variant on the hotspot implementation. In this context, the latter would be more appropriate. Solution: The proposed "correct" behaviour was to follow the trend laid down by corretto, dragonwell, etc, by having the bisheng smoke tests' default value for JDK_IMPL set to "hotspot". |
@smlambert Are you happy with this change now that the context has been clarified? |
Bisheng JDK is hotspot implementation.
This change can passed JDK_IMPL as "hotspot" to jenkins job when bisheng is tested, I think.