Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maketest.sh: Add process cleanup for Windows at the end of testing #2059

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

sxa
Copy link
Member

@sxa sxa commented Nov 18, 2020

Hopefully fixes adoptium/infrastructure#1573 by checking for, and attempting to stop, java processes on the machine that have been created since the time that the test job was started. This should prevent process leaks across jobs which cause a number of failures either of failed tests or locked directories that cannot be cleaned up. Equivalent functionality may well be moved into TKG at a later point.

Draft until I've verified that the functionaliy doesn't cause any new breaks

As per adoptium/infrastructure#1669 (comment) and #2058 (comment)

Signed-off-by: Stewart X Addison sxa@redhat.com

@sxa sxa added the bug label Nov 18, 2020
@sxa sxa added this to the November 2020 milestone Nov 18, 2020
@sxa sxa self-assigned this Nov 18, 2020
@sxa sxa force-pushed the win_process_killer branch from 0481d37 to d2b5259 Compare November 18, 2020 13:27
maketest.sh Show resolved Hide resolved
maketest.sh Show resolved Hide resolved
@sxa sxa force-pushed the win_process_killer branch from d2b5259 to 57a5afa Compare November 18, 2020 16:23
@sxa sxa marked this pull request as ready for review November 18, 2020 16:32
@sxa sxa requested a review from smlambert November 18, 2020 16:32
@sxa
Copy link
Member Author

sxa commented Nov 18, 2020

FYI @Willsparker :-)

@smlambert
Copy link
Contributor

smlambert commented Nov 18, 2020

Grinders: 4834, 4835, and 4838 plus PR github workflows pass (with one unrelated exception on jdk15, as expected, since this code is only invoked if on Jenkins / EXECUTOR_NUMBER defined).

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments, overall LGTM, will await Grinders to complete (and if you wanted to update echo statements/comments or not) before merging.

maketest.sh Outdated Show resolved Hide resolved
maketest.sh Outdated Show resolved Hide resolved
maketest.sh Outdated Show resolved Hide resolved
maketest.sh Show resolved Hide resolved
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows machines can't delete workspace files
3 participants