-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maketest.sh: Add process cleanup for Windows at the end of testing #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxa
force-pushed
the
win_process_killer
branch
from
November 18, 2020 13:27
0481d37
to
d2b5259
Compare
karianna
reviewed
Nov 18, 2020
sxa
force-pushed
the
win_process_killer
branch
from
November 18, 2020 16:23
d2b5259
to
57a5afa
Compare
FYI @Willsparker :-) |
5 tasks
smlambert
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor comments, overall LGTM, will await Grinders to complete (and if you wanted to update echo statements/comments or not) before merging.
Signed-off-by: Stewart X Addison <sxa@redhat.com>
sxa
force-pushed
the
win_process_killer
branch
from
November 18, 2020 18:09
57a5afa
to
9a2cd84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes adoptium/infrastructure#1573 by checking for, and attempting to stop, java processes on the machine that have been created since the time that the test job was started. This should prevent process leaks across jobs which cause a number of failures either of failed tests or locked directories that cannot be cleaned up. Equivalent functionality may well be moved into TKG at a later point.
Draft until I've verified that the functionaliy doesn't cause any new breaksAs per adoptium/infrastructure#1669 (comment) and #2058 (comment)
Signed-off-by: Stewart X Addison sxa@redhat.com