Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilise new Vendor name instead of adopt's patch with company name #1020

Closed
karianna opened this issue Apr 6, 2019 · 11 comments
Closed

Utilise new Vendor name instead of adopt's patch with company name #1020

karianna opened this issue Apr 6, 2019 · 11 comments
Assignees
@lumpfish
Labels
bug Issues that are problems in the code as reported by the community good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed
Milestone
January 2020

Comments

@karianna
Copy link
Contributor

karianna commented Apr 6, 2019

No description provided.

@karianna karianna added the bug Issues that are problems in the code as reported by the community label Apr 6, 2019
@karianna karianna added this to the April 2019 milestone Apr 6, 2019
@karianna karianna mentioned this issue Apr 12, 2019
Closed
@karianna karianna modified the milestones: April 2019, May 2019 May 1, 2019
@karianna karianna modified the milestones: May 2019, June 2019 Jun 3, 2019
@karianna karianna modified the milestones: June 2019, July 2019 Jul 5, 2019
@karianna karianna modified the milestones: July 2019, August 2019 Aug 6, 2019
@karianna karianna modified the milestones: August 2019, September 2019 Sep 2, 2019
@karianna karianna modified the milestones: September 2019, October 2019 Oct 4, 2019
@karianna karianna modified the milestones: October 2019, November 2019 Nov 3, 2019
@sxa sxa added the good first issue Issues that have been deemed "easy" and excellent for new contributors label Dec 3, 2019
@sxa sxa modified the milestones: November 2019, Icebox Dec 3, 2019
@lumpfish
Copy link
Contributor

lumpfish commented Dec 10, 2019 •
edited
Loading

I have run an openjdk build (not adoptopenjdk build) using

bash configure --with-vendor-name=AdoptOpenJDK

and that results in a jdk with the following properties:

java.vendor = AdoptOpenJDK
java.vm.vendor = AdoptOpenJDK

which looks like the result we want.
The AdoptOpenJDK build currently uses its --with-company-name build configure argument (which is specific to AdoptOpenJDK).
So there appear to be two parts to this:

  1. Pass --with-vendor-name rather than --with-company-name to build configure in the build scripts
  2. No longer apply the --with-company-name patch to the openjdk git clone

@karianna / @johnoliver - does that sound right or is there more to it than that?

@sxa sxa modified the milestones: Icebox, December 2019 Dec 10, 2019
@sxa
Copy link
Member

sxa commented Dec 10, 2019

I would have thought that ideally we'd want java.vm.vendor to still be Oracle, although if Simon's investigation is correct the options doesn't allow you to set one of those and not the other.

@johnoliver
Copy link
Contributor

can you paste in the full java -version string that gets produced. But assuming it give us what we need and removes a patch...sounds good

@lumpfish
Copy link
Contributor

Full output from

java -XshowSettings:properties -version

Property settings:
    awt.toolkit = sun.awt.X11.XToolkit
    file.encoding = UTF-8
    file.encoding.pkg = sun.io
    file.separator = /
    java.awt.graphicsenv = sun.awt.X11GraphicsEnvironment
    java.awt.printerjob = sun.print.PSPrinterJob
    java.class.path = .
    java.class.version = 52.0
    java.endorsed.dirs = /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/endorsed
    java.ext.dirs = /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/ext
        /usr/java/packages/lib/ext
    java.home = /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre
    java.io.tmpdir = /tmp
    java.library.path = /usr/java/packages/lib/amd64
        /usr/lib64
        /lib64
        /lib
        /usr/lib
    java.runtime.name = OpenJDK Runtime Environment
    java.runtime.version = 1.8.0-internal-username_2019_12_10_12_48-b00
    java.specification.name = Java Platform API Specification
    java.specification.vendor = Oracle Corporation
    java.specification.version = 1.8
    java.vendor = AdoptOpenJDK
    java.vendor.url = http://java.oracle.com/
    java.vendor.url.bug = http://bugreport.sun.com/bugreport/
    java.version = 1.8.0-internal
    java.vm.info = mixed mode
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 1.8
    java.vm.vendor = AdoptOpenJDK
    java.vm.version = 25.71-b00
    line.separator = \n 
    os.arch = amd64
    os.name = Linux
    os.version = 4.15.0-45-generic
    path.separator = :
    sun.arch.data.model = 64
    sun.boot.class.path = /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/resources.jar
        /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/rt.jar
        /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/sunrsasign.jar
        /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/jsse.jar
        /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/jce.jar
        /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/charsets.jar
        /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/jfr.jar
        /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/classes
    sun.boot.library.path = /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/jre/lib/amd64
    sun.cpu.endian = little
    sun.cpu.isalist = 
    sun.desktop = gnome
    sun.io.unicode.encoding = UnicodeLittle
    sun.java.launcher = SUN_STANDARD
    sun.jnu.encoding = UTF-8
    sun.management.compiler = HotSpot 64-Bit Tiered Compilers
    sun.os.patch.level = unknown
    user.country = GB
    user.dir = /home/username/hg/jdk8u/build/linux-x86_64-normal-server-release/images
    user.home = /home/username
    user.language = en
    user.name = username
    user.timezone = 

openjdk version "1.8.0-internal"
OpenJDK Runtime Environment (build 1.8.0-internal-username_2019_12_10_12_48-b00)
OpenJDK 64-Bit Server VM (build 25.71-b00, mixed mode)

@sxa sxa mentioned this issue Dec 31, 2019
Closed
@sxa sxa mentioned this issue Dec 31, 2019
Open
@sxa sxa modified the milestones: December 2019, January 2020 Dec 31, 2019
@karianna
Copy link
Contributor Author

karianna commented Jan 8, 2020

I would have thought that ideally, we'd want java.vm.vendor to still be Oracle, although if Simon's investigation is correct the options don't allow you to set one of those and not the other.

It looks like our existing patch sets this to AdoptOpenJDK, so we're being consistent.

@karianna
Copy link
Contributor Author

karianna commented Jan 8, 2020

@lumpfish - I think you can go ahead and make the PR change (assuming this is a builds script change which I suspect it is). Worth co-ordinating with @johnoliver to then remove/disable our patch.

@lumpfish
Copy link
Contributor

lumpfish commented Jan 8, 2020

Created #1461 for the --with-vendor-name part (not the patch removal). I don't think it's possible to test using my fork of openjdk-build in the Jenkins pipeline - @johnoliver / @sxa555 - please tell me if that's incorrect and I can test it.

@sxa
Copy link
Member

sxa commented Jan 8, 2020 •
edited
Loading

It is possible :-) Have initiated https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/test-build-script-pull-request/238/ to test it

EDIT: I should probably have included an OpenJ9 version as well, but if you want to kick off another feel free - parameters are pretty self-explanatory

@lumpfish
Copy link
Contributor

lumpfish commented Jan 14, 2020 •
edited
Loading

Output of

java -XshowSettings:properties -version

from builds created from the openjdk-build fork / branch in PR #1461:

jdk8u242-b06_hotspot:
Property settings:
    awt.toolkit = sun.awt.X11.XToolkit
    file.encoding = UTF-8
    file.encoding.pkg = sun.io
    file.separator = /
    java.awt.graphicsenv = sun.awt.X11GraphicsEnvironment
    java.awt.printerjob = sun.print.PSPrinterJob
    java.class.path = .
    java.class.version = 52.0
    java.endorsed.dirs = /home/user/Downloads/jdk8u242-b06/jre/lib/endorsed
    java.ext.dirs = /home/user/Downloads/jdk8u242-b06/jre/lib/ext
        /usr/java/packages/lib/ext
    java.home = /home/user/Downloads/jdk8u242-b06/jre
    java.io.tmpdir = /tmp
    java.library.path = /usr/java/packages/lib/amd64
        /usr/lib64
        /lib64
        /lib
        /usr/lib
    java.runtime.name = OpenJDK Runtime Environment
    java.runtime.version = 1.8.0_242-202001131717-b06
    java.specification.name = Java Platform API Specification
    java.specification.vendor = Oracle Corporation
    java.specification.version = 1.8
    java.vendor = AdoptOpenJDK
    java.vendor.url = http://java.oracle.com/
    java.vendor.url.bug = http://bugreport.sun.com/bugreport/
    java.version = 1.8.0_242
    java.vm.info = mixed mode
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 1.8
    java.vm.vendor = AdoptOpenJDK
    java.vm.version = 25.242-b06
    line.separator = \n 
    os.arch = amd64
    os.name = Linux
    os.version = 4.15.0-29-generic
    path.separator = :
    sun.arch.data.model = 64
    sun.boot.class.path = /home/user/Downloads/jdk8u242-b06/jre/lib/resources.jar
        /home/user/Downloads/jdk8u242-b06/jre/lib/rt.jar
        /home/user/Downloads/jdk8u242-b06/jre/lib/sunrsasign.jar
        /home/user/Downloads/jdk8u242-b06/jre/lib/jsse.jar
        /home/user/Downloads/jdk8u242-b06/jre/lib/jce.jar
        /home/user/Downloads/jdk8u242-b06/jre/lib/charsets.jar
        /home/user/Downloads/jdk8u242-b06/jre/lib/jfr.jar
        /home/user/Downloads/jdk8u242-b06/jre/classes
    sun.boot.library.path = /home/user/Downloads/jdk8u242-b06/jre/lib/amd64
    sun.cpu.endian = little
    sun.cpu.isalist = 
    sun.desktop = gnome
    sun.io.unicode.encoding = UnicodeLittle
    sun.java.launcher = SUN_STANDARD
    sun.jnu.encoding = UTF-8
    sun.management.compiler = HotSpot 64-Bit Tiered Compilers
    sun.os.patch.level = unknown
    user.country = GB
    user.dir = /home/user/Downloads
    user.home = /home/user
    user.language = en
    user.name = user
    user.timezone = 

openjdk version "1.8.0_242"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_242-202001131717-b06)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.242-b06, mixed mode)

jdk-11.0.6+9.hotspot
Property settings:
    awt.toolkit = sun.awt.X11.XToolkit
    file.encoding = UTF-8
    file.separator = /
    java.awt.graphicsenv = sun.awt.X11GraphicsEnvironment
    java.awt.printerjob = sun.print.PSPrinterJob
    java.class.path = 
    java.class.version = 55.0
    java.home = /home/user/Downloads/jdk-11.0.6+9
    java.io.tmpdir = /tmp
    java.library.path = /usr/java/packages/lib
        /usr/lib64
        /lib64
        /lib
        /usr/lib
    java.runtime.name = OpenJDK Runtime Environment
    java.runtime.version = 11.0.6+9-202001131745
    java.specification.name = Java Platform API Specification
    java.specification.vendor = Oracle Corporation
    java.specification.version = 11
    java.vendor = AdoptOpenJDK
    java.vendor.url = https://adoptopenjdk.net/
    java.vendor.url.bug = https://github.com/AdoptOpenJDK/openjdk-support/issues
    java.vendor.version = AdoptOpenJDK
    java.version = 11.0.6
    java.version.date = 2020-01-14
    java.vm.compressedOopsMode = 32-bit
    java.vm.info = mixed mode
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 11
    java.vm.vendor = AdoptOpenJDK
    java.vm.version = 11.0.6+9-202001131745
    jdk.debug = release
    line.separator = \n 
    os.arch = amd64
    os.name = Linux
    os.version = 4.15.0-29-generic
    path.separator = :
    sun.arch.data.model = 64
    sun.boot.library.path = /home/user/Downloads/jdk-11.0.6+9/lib
    sun.cpu.endian = little
    sun.cpu.isalist = 
    sun.desktop = gnome
    sun.io.unicode.encoding = UnicodeLittle
    sun.java.launcher = SUN_STANDARD
    sun.jnu.encoding = UTF-8
    sun.management.compiler = HotSpot 64-Bit Tiered Compilers
    sun.os.patch.level = unknown
    user.country = GB
    user.dir = /home/user/Downloads
    user.home = /home/user
    user.language = en
    user.name = user
    user.timezone = 

openjdk version "11.0.6" 2020-01-14
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.6+9-202001131745)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.6+9-202001131745, mixed mode)

jdk-13.0.1+9.hotspot
Property settings:
    file.encoding = UTF-8
    file.separator = /
    java.class.path = 
    java.class.version = 57.0
    java.home = /home/user/Downloads/jdk-13.0.1+9
    java.io.tmpdir = /tmp
    java.library.path = /usr/java/packages/lib
        /usr/lib64
        /lib64
        /lib
        /usr/lib
    java.runtime.name = OpenJDK Runtime Environment
    java.runtime.version = 13.0.1+9-202001131807
    java.specification.name = Java Platform API Specification
    java.specification.vendor = Oracle Corporation
    java.specification.version = 13
    java.vendor = AdoptOpenJDK
    java.vendor.url = https://adoptopenjdk.net/
    java.vendor.url.bug = https://github.com/AdoptOpenJDK/openjdk-support/issues
    java.vendor.version = AdoptOpenJDK
    java.version = 13.0.1
    java.version.date = 2019-10-15
    java.vm.compressedOopsMode = 32-bit
    java.vm.info = mixed mode, sharing
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 13
    java.vm.vendor = AdoptOpenJDK
    java.vm.version = 13.0.1+9-202001131807
    jdk.debug = release
    line.separator = \n 
    os.arch = amd64
    os.name = Linux
    os.version = 4.15.0-29-generic
    path.separator = :
    sun.arch.data.model = 64
    sun.boot.library.path = /home/user/Downloads/jdk-13.0.1+9/lib
    sun.cpu.endian = little
    sun.io.unicode.encoding = UnicodeLittle
    sun.java.launcher = SUN_STANDARD
    sun.jnu.encoding = UTF-8
    sun.management.compiler = HotSpot 64-Bit Tiered Compilers
    user.country = GB
    user.dir = /home/user/Downloads
    user.home = /home/user
    user.language = en
    user.name = user

openjdk version "13.0.1" 2019-10-15
OpenJDK Runtime Environment AdoptOpenJDK (build 13.0.1+9-202001131807)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 13.0.1+9-202001131807, mixed mode, sharing)

@lumpfish
Copy link
Contributor

For reference, this are the system properties for the previous AdoptOpenJDK release:

jdk8u232-b09_hotspot
Property settings:
    awt.toolkit = sun.awt.X11.XToolkit
    file.encoding = UTF-8
    file.encoding.pkg = sun.io
    file.separator = /
    java.awt.graphicsenv = sun.awt.X11GraphicsEnvironment
    java.awt.printerjob = sun.print.PSPrinterJob
    java.class.path = .
    java.class.version = 52.0
    java.endorsed.dirs = /home/user/Downloads/jdk8u232-b09/jre/lib/endorsed
    java.ext.dirs = /home/user/Downloads/jdk8u232-b09/jre/lib/ext
        /usr/java/packages/lib/ext
    java.home = /home/user/Downloads/jdk8u232-b09/jre
    java.io.tmpdir = /tmp
    java.library.path = /usr/java/packages/lib/amd64
        /usr/lib64
        /lib64
        /lib
        /usr/lib
    java.runtime.name = OpenJDK Runtime Environment
    java.runtime.version = 1.8.0_232-b09
    java.specification.name = Java Platform API Specification
    java.specification.vendor = Oracle Corporation
    java.specification.version = 1.8
    java.vendor = AdoptOpenJDK
    java.vendor.url = http://java.oracle.com/
    java.vendor.url.bug = http://bugreport.sun.com/bugreport/
    java.version = 1.8.0_232
    java.vm.info = mixed mode
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 1.8
    java.vm.vendor = AdoptOpenJDK
    java.vm.version = 25.232-b09
    line.separator = \n 
    os.arch = amd64
    os.name = Linux
    os.version = 4.15.0-29-generic
    path.separator = :
    sun.arch.data.model = 64
    sun.boot.class.path = /home/user/Downloads/jdk8u232-b09/jre/lib/resources.jar
        /home/user/Downloads/jdk8u232-b09/jre/lib/rt.jar
        /home/user/Downloads/jdk8u232-b09/jre/lib/sunrsasign.jar
        /home/user/Downloads/jdk8u232-b09/jre/lib/jsse.jar
        /home/user/Downloads/jdk8u232-b09/jre/lib/jce.jar
        /home/user/Downloads/jdk8u232-b09/jre/lib/charsets.jar
        /home/user/Downloads/jdk8u232-b09/jre/lib/jfr.jar
        /home/user/Downloads/jdk8u232-b09/jre/classes
    sun.boot.library.path = /home/user/Downloads/jdk8u232-b09/jre/lib/amd64
    sun.cpu.endian = little
    sun.cpu.isalist = 
    sun.desktop = gnome
    sun.io.unicode.encoding = UnicodeLittle
    sun.java.launcher = SUN_STANDARD
    sun.jnu.encoding = UTF-8
    sun.management.compiler = HotSpot 64-Bit Tiered Compilers
    sun.os.patch.level = unknown
    user.country = GB
    user.dir = /home/user/Downloads
    user.home = /home/user
    user.language = en
    user.name = user
    user.timezone = 

openjdk version "1.8.0_232"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)

@lumpfish
Copy link
Contributor

#1461 is merged so this should be OK to close.

@jerboaa jerboaa closed this as completed Jan 28, 2020
@M-Davies M-Davies mentioned this issue May 19, 2020
Closed
@hendrikebbers hendrikebbers added good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed and removed good first issue Issues that have been deemed "easy" and excellent for new contributors labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumpfish lumpfish

Labels
bug Issues that are problems in the code as reported by the community good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
6 participants
@karianna @jerboaa @johnoliver @sxa @hendrikebbers @lumpfish