-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java.vendor.version only displays "AdoptOpenJDK" #1387
Comments
For information, these are the current property settings for jdk11 (hotspot and openj9):
Since AdoptOpenJDK has the notion of the 'build suffix', perhaps this property would be a place to capture that information (e.g. 11.0.4+11.4)? |
Related: #1020 |
@lumpfish Did we have any discussions on what the values of this should be? |
ping @lumpfish ref #1387 (comment) |
No discussions I'm aware of. |
This is being reverted. |
It may be useful to look at what other distros set this property as for a start. |
|
Bell Soft Liberica doesn't have it (couldn't find it on the Mac, at least) |
java.vendor.version is optional, openjdk wanted to remove it at one point: https://bugs.openjdk.java.net/browse/JDK-8216383 |
I quite like using our metadata version string: A release would be: |
@smlambert just one thought going forward, what's the position on the word AdoptOpenJDK vs EclipseAdoptium ? |
Once we complete our transition to Eclipse Foundation and produce our first release (TCKed) under their banner, those properties (and certs we use, etc) will get updated, java.vendor = Eclipse, etc., so you could plan to create this metadata version string where java.vendor.version = java.vendor + version |
Example here:
|
|
The System property
java.vendor.version
should provide better pointer to the source code version used by AdoptOpenJDK to build OpenJDK. Currently, it only saysAdoptOpenJDK
.The text was updated successfully, but these errors were encountered: