Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.vendor.version only displays "AdoptOpenJDK" #1387

Open
brunoborges opened this issue Nov 17, 2019 · 15 comments
Open

java.vendor.version only displays "AdoptOpenJDK" #1387

brunoborges opened this issue Nov 17, 2019 · 15 comments
Assignees
Labels
bug Issues that are problems in the code as reported by the community
Milestone

Comments

@brunoborges
Copy link

The System property java.vendor.version should provide better pointer to the source code version used by AdoptOpenJDK to build OpenJDK. Currently, it only says AdoptOpenJDK.

@karianna karianna added the bug Issues that are problems in the code as reported by the community label Nov 17, 2019
@karianna karianna modified the milestone: November 2019 Nov 17, 2019
@sxa sxa added this to the December 2019 milestone Dec 3, 2019
@lumpfish
Copy link
Contributor

lumpfish commented Dec 4, 2019

For information, these are the current property settings for jdk11 (hotspot and openj9):

hotspot:
    java.vendor = AdoptOpenJDK
    java.vendor.url = https://adoptopenjdk.net/
    java.vendor.url.bug = https://github.com/AdoptOpenJDK/openjdk-build/issues
    java.vendor.version = AdoptOpenJDK
    java.version = 11.0.5
    java.version.date = 2019-10-15
    java.vm.compressedOopsMode = Zero based
    java.vm.info = mixed mode
    java.vm.name = OpenJDK 64-Bit Server VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 11
    java.vm.vendor = AdoptOpenJDK
    java.vm.version = 11.0.5+10
openj9:
    java.vendor = Eclipse OpenJ9
    java.vendor.url = http://www.eclipse.org/openj9
    java.vendor.version = AdoptOpenJDK
    java.version = 11.0.5
    java.version.date = 2019-10-15
    java.vm.info = JRE 11 Windows 10 amd64-64-Bit Compressed References 20191016_357 (JIT enabled, AOT enabled)
OpenJ9   - 77c1cf708
OMR      - 20db4fbc
JCL      - 2a7af5674b based on jdk-11.0.5+10
    java.vm.name = Eclipse OpenJ9 VM
    java.vm.specification.name = Java Virtual Machine Specification
    java.vm.specification.vendor = Oracle Corporation
    java.vm.specification.version = 11
    java.vm.vendor = Eclipse OpenJ9
    java.vm.version = openj9-0.17.0
    jdk.extensions.name = Extensions for OpenJDK for Eclipse OpenJ9
    jdk.extensions.version = 11.0.5.0

Since AdoptOpenJDK has the notion of the 'build suffix', perhaps this property would be a place to capture that information (e.g. 11.0.4+11.4)?

@sxa sxa modified the milestones: December 2019, January 2020 Dec 31, 2019
@sxa
Copy link
Member

sxa commented Dec 31, 2019

Related: #1020

@karianna karianna modified the milestones: January 2020, February 2020 Feb 3, 2020
@sxa
Copy link
Member

sxa commented Mar 3, 2020

@lumpfish Did we have any discussions on what the values of this should be?

@sxa sxa modified the milestones: February 2020, March 2020 Mar 3, 2020
@karianna karianna modified the milestones: March 2020, April 2020 Apr 2, 2020
@karianna karianna modified the milestones: April 2020, May 2020 May 4, 2020
@karianna karianna modified the milestones: May 2020, June 2020 Jun 1, 2020
@M-Davies
Copy link

M-Davies commented Jun 5, 2020

ping @lumpfish ref #1387 (comment)

@lumpfish
Copy link
Contributor

lumpfish commented Jun 8, 2020

No discussions I'm aware of.

@austin0
Copy link
Contributor

austin0 commented Oct 19, 2020

This has been changed in #2073 to default to the variant being built.

This is being reverted.

@smlambert
Copy link
Contributor

It may be useful to look at what other distros set this property as for a start.

@andrew-m-leonard
Copy link
Contributor

java.vendor.version = Zulu16.28+11-CA
java.vendor.version = Corretto-11.0.10.9.1

@aahlenst
Copy link
Contributor

Bell Soft Liberica doesn't have it (couldn't find it on the Mac, at least)

@andrew-m-leonard
Copy link
Contributor

Bell Soft Liberica doesn't have it (couldn't find it on the Mac, at least)

java.vendor.version is optional, openjdk wanted to remove it at one point: https://bugs.openjdk.java.net/browse/JDK-8216383

@andrew-m-leonard
Copy link
Contributor

andrew-m-leonard commented Mar 19, 2021

I quite like using our metadata version string:
"version": "11.0.11+7-202103181819"
and stick AdoptOpenJDK on the front, so:
“AdoptOpenJDK-11.0.11+7-202103181819”
for a nightly build

A release would be:
"AdoptOpenJDK-16+36"

@andrew-m-leonard
Copy link
Contributor

@smlambert just one thought going forward, what's the position on the word AdoptOpenJDK vs EclipseAdoptium ?

@smlambert
Copy link
Contributor

Once we complete our transition to Eclipse Foundation and produce our first release (TCKed) under their banner, those properties (and certs we use, etc) will get updated, java.vendor = Eclipse, etc., so you could plan to create this metadata version string where java.vendor.version = java.vendor + version

@andrew-m-leonard
Copy link
Contributor

Example here:

    java.vendor.version = AdoptOpenJDK-11.0.11+7-202103230931

openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+7-202103230931 (build 11.0.11+7-202103230931)
OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+7-202103230931 (build 11.0.11+7-202103230931, mixed mode)

@andrew-m-leonard
Copy link
Contributor

    java.vendor.version = AdoptOpenJDK-16+36

openjdk version "16" 2021-03-16
OpenJDK Runtime Environment AdoptOpenJDK-16+36 (build 16+36)
OpenJDK 64-Bit Server VM AdoptOpenJDK-16+36 (build 16+36, mixed mode, sharing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community
Projects
None yet
Development

No branches or pull requests

9 participants