Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --with-vendor-name rather than --with-company-name on jdk8 #1461

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Use --with-vendor-name rather than --with-company-name on jdk8 #1461

merged 1 commit into from
Jan 22, 2020

Conversation

lumpfish
Copy link
Contributor

@lumpfish lumpfish commented Jan 8, 2020

Signed-off-by: Simon Rushton rushton@uk.ibm.com

Use --with-vendor-name rather than --with-company-name on jdk8
25a8126 
Signed-off-by: Simon Rushton <rushton@uk.ibm.com>
@lumpfish lumpfish requested a review from johnoliver January 8, 2020 14:29
@lumpfish lumpfish mentioned this pull request Jan 8, 2020
Closed
@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Jan 9, 2020
@karianna karianna added this to the January 2020 milestone Jan 9, 2020
sxa
sxa requested changes Jan 14, 2020
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this hasn't been approved yet I'm rejecting this until at least the end of the week while we do the quarterly releases

@karianna
Copy link
Contributor

@johnoliver - we probably need to review this but then land with care (back out the other patch).

@johnoliver
Copy link
Contributor

yeah will do when the release is out

@karianna karianna merged commit 4b42c90 into adoptium:master Jan 22, 2020
@sxa
Copy link
Member

sxa commented Jan 22, 2020

I would rather this hadn't been landed (hence my rejection of it) since we have not done the final quarterly OpenJ9 JDK8 builds.

@karianna
Copy link
Contributor

I would rather this hadn't been landed (hence my rejection of it) since we have not done the final quarterly OpenJ9 JDK8 builds.

Apologies - I hadn't caught the extra delay there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa requested changes

@gdams gdams gdams approved these changes

@johnoliver johnoliver johnoliver approved these changes

Assignees
No one assigned
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@lumpfish @karianna @johnoliver @sxa @gdams