Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: Correct workspace path for Windows build #1724

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

Willsparker
Copy link
Contributor

fixes: adoptium/infrastructure#1284
ref: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x64-hotspot/554/console

A build issue introduced with #1647 and #1639 . The softlayer Windows build machines (unlike the azure ones), don't have a CYGWIN_WORKSPACE variable setup for them. This causes them to default to C:/cygwin64/tmp/openjdk-build/ currently, however that causes an issue when the build is trying to find the path:

c1xx: fatal error C1083: Cannot open source file: '../../../../..c:/cygwin64/tmp/openjdk-build/workspace/build/src/build/windows-x86_64-normal-clientANDserver-release/hotspot/variant-server/libjvm/gtest/objs/BUILD_GTEST_LIBJVM_pch.cpp': No such file or directory

FYI @karianna @gdams @sxa

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment as to why this change is being made :-)

@karianna karianna added the bug Issues that are problems in the code as reported by the community label Apr 30, 2020
@karianna karianna added this to the April 2020 milestone Apr 30, 2020
@Willsparker
Copy link
Contributor Author

@karianna Done! :-) Updated the issue that gives justification for the path, and then linked to that comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release build failure on Softlayer/JDK11/Windows
3 participants