Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: Correct workspace path for Windows build #1724

Merged
merged 2 commits into from
Apr 30, 2020
Merged

pipelines: Correct workspace path for Windows build #1724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1548859
pipelines: Correct workspace path for Windows build
Apr 30, 2020
3d1bdff
Add comment explaining the choice for the path
Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pipelines/build/common/openjdk_build_pipeline.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,8 @@ class Build {
// This is to avoid windows path length issues.
context.echo("checking ${buildConfig.TARGET_OS}")
if (buildConfig.TARGET_OS == "windows") {
def workspace = "C:/cygwin64/tmp/openjdk-build/"
// See https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1284#issuecomment-621909378 for justification of the below path
def workspace = "C:/workspace/openjdk-build/"
if (env.CYGWIN_WORKSPACE) {
workspace = env.CYGWIN_WORKSPACE
}
Expand Down