-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Loongson jdk build #3134
Support for Loongson jdk build #3134
Conversation
Hi @Panxuefeng-loongson - Are you able to sign the Eclipse CLA? |
@Panxuefeng-loongson the Loongsoon build itself seems to be failing: https://github.com/adoptium/temurin-build/actions/runs/3327315068/jobs/5515528475 |
I only tested it on my local machine, I will fix the build failure in docker. |
c7bc562
to
0d69b07
Compare
I clicked on this link: https://accounts.eclipse.org/user/register?destination=legal/eca/validation/125041 and want to register an account, an error occurred while submitting information: The answer you entered for the CAPTCHA was not correct. Could you please tell me where to sign the cla agreement? |
This has some guidance for ECA signing, hopefully it can help: https://adoptium.net/docs/eca-sign-off |
I have signed the Eclipse CLA. Thanks for your help @karianna @smlambert |
ECA validation now passes 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, broadly looks good.
62d7be6
to
f36b45e
Compare
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
…dopt-build-farm.sh
fdc9cd4
to
e2bd021
Compare
e2bd021
to
476f3c4
Compare
Assume after we enable this feature (do nightly+weekly jdk8 build to support loongson), we need update ci-jenkins-pipeline as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Please note there is a separate decision whether to add build agents at Adoptium, but at least this should enable folks to build locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the patch broke the builds? @Panxuefeng-loongson please have a look.
Some errors have occurred, i will check it |
if [ "${ARCHITECTURE}" == "loongarch64" ]; then | ||
echo Loongson jdk8 requires a Loongson boot JDK - downloading one ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the architecture check required? Doesn't it require a Loongson JVM to build the Loonson codebase every time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the architecture check required? Doesn't it require a Loongson JVM to build the Loonson codebase every time?
I found that in jenkins jobs, Loongson codebase will build on x86 machine. If not architecture check, x86 machine will use the LoongArch jdk binary, and an error will occur when VARIANT is BUILD_VARIANT_LOONGSON. Maybe my ideas are wrong and welcome to give your opinion.
2255ccd
to
446290d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
Couple of shellcheck warnings:
|
I will fix this problem, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping |
@Panxuefeng-loongson this looks good to me, on the topic of FreeType, I propose that we merge #3188 first which would then allow us to specify a different FreeType tag for Loongson JDK. What do you think? |
This option looks great and I agree with your solution |
Out of interest, what FreeType version does Loongson JDK need @Panxuefeng-loongson? |
Recent versions of freetype have met the Loongson JDK build, because config.guess and config.sub support LoongArch from this point onwards: http://git.savannah.gnu.org/gitweb/?p=config.git;a=commit;h=c8ddc8472f8efcadafc1ef53ca1d863415fddd5f, It's been two years since. I have checked the last few versions of freetype and they all meet our needs. Thanks @gdams |
this has been stale for over a year, converting to "draft", if no longer needed please close. |
Closing on the basis that Temurin will not be integrating builds on this (And the PR would now require a bit of a rebase). If there is a need for this for people building outside temurin then it can be revisited. |
Hi,
I'm a member of the openjdk development team from Loongson. We intend to distribute binaries of JDK via adoptium. LoongArch code was based on openjdk 8, here is repo on github:https://github.com/loongson/jdk8u. LoongArch is a risc architecture, developed by Loongson Technology. Currently, the freetype version needs to be updated, see: #3120. So this pr can't be merged yet, it's just used to ask for your opinion in advance.
We intend to use jdk8 as a trial and look forward to participating in more adoptium community work.
Thanks