Build-related upstream patches 1 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let it be autodiscovered instead to avoid cmake thinking it's crosscompiling builds where host = target. This resolves a cmake configure error in MSYS2 caused by CMAKE_CROSSCOMPILING checks in monero-project#4294.
…ion /monero#4178 Introduced with GCC 8.2
…#4232 This is GCC/x86/x86_64 only
This proposal allows to perform multiple compilation from different branch/arch in
separate directories.
Example:
build
├── GNU_Linux
│ ├── multi-compilation
│ │ └── release
│ └── NanoS-USBHID
│ └── release
└── Msys
└── NanoS-USBHID
└── release
Edit 1:
Try to handle special char as : / \ .
--data-dir in unit test not yet tested
Edit 2:
donot use param for uname. -o is not supported by MacOS.
Rebased by moneromooo, with a sensible commit message
Rebased and squashed by moneromooo
rebased by moneromooo
Adds CMake check that pulls from the different git remotes and checks if there is any output.
The Docker image is failing to build, as the submodules are not being explicitly initialized and updated. Fixes: monero-project#4582 Signed-off-by: Tyler Baker <tyler@foundries.io>
The cmake thread detection just ain't enough to always work
Increased swap size on raspberry pi compiling guide, since it might crash if the raspberry has any service runing in the background
|
builds for andriod on linux & docker now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to pull all the build-related upstream patches up to the latest commit so that all the upstream fixes for build issues can be reflected in a timely manner. This PR includes the following upstream PRs:
Note that this PR skips several important patches that make significant changes to the codebase, specifically:
These patches will be merged later along with the rest of the codebase being updated in order. Because of this circumstance, some upstream patches taken in this PR needed conflict resolution.
EDIT:
Added monero-project#4074 in order to circumvent a build halt caused by
-Werror.