-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check if submodules need to be updated #4501
Conversation
Why bother checking? just run |
Do you mean why bother with the pr at all, or why bother using git pull?
|
I see the MANUAL_SUBMODULES flag, which can allow this to be bypassed, and that makes me think of this %@!&*%# firefox which pretty much always enables privacy invading stuff by default, which means that if you don't know in advance what's coming, you run that stuff at least once and curse seven generations of its children before you have a chance to disable the new trap. And that's if you're lucky and realize they added somehting. Here it's the same: you'll get to run git submodule update at least once before you realize this is now done automatically. That said, it's something needed, not some shitty thing some marketer wanted, so much less bad, but I really wanted to rant about firefox's underhanded ways today, so there you go. Anyway, looking at the patch, you still hit the network I think. I just looked up where the submodule hashes are kept: git ls-tree HEAD external/unbound | awk 'print $3' You can then compare with the top hash, and can either go ahead or error out without hitting the network. |
But then the wallet does a DNS lookup. Hmm. What to do... |
Adds CMake check that pulls from the different git remotes and checks if there is any output.
5da63d5
to
fb3593c
Compare
Force pushed a new approach as to @moneromooo-monero 's suggestion. Updated PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
fb3593c Add check if submodules need to be updated (TheCharlatan)
fb3593c Add check if submodules need to be updated (TheCharlatan)
fb3593c Add check if submodules need to be updated (TheCharlatan)
This is a replacement pr for #3926 . I am not sure this actually does what I inteded. Please suggest better ways to make the check.
Adds CMake check that checks if the commited hash of the submodule is the same as the currently checked out hash in the submodule directory.