Split folders and preserve quoted names #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a folder in the `MailMover` section includes a
space (e.g. `[Gmail].Sent Mail`) there is currently no way to quote
the folder name such as to preserve the space in it. This change
replaces the standard `split()` function with one that understands
quotes. For the above example, the following config entry works:
folders = "[Gmail].Sent Mail" other_folder
Fixes: afewmail#97
Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
nicolasbock
force-pushed
the
issue_97
branch
from
c181144 to
978de94
Compare
|
Thanks for your PR! The config parser is something that I'd eventually like to see replaced with ConfigObj anyhow, but that will most likely introduce more format changes down the road anyhow ;-) Can you also update |
|
Done @flokli . |
This change updates the MailMover documentation to explain how to deal with folder names that contain whitespace. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
nicolasbock
force-pushed
the
issue_97
branch
from
e39e22f to
4060e3a
Compare
flokli
approved these changes
Sep 20, 2018
|
Thanks! |
nicolasbock
added a commit
to nicolasbock/afew
that referenced
this pull request
Jan 8, 2019
When using folder names containing whitespace characters (see PR afewmail#206) the folder part of the notmuch search query needs to be quoted. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a folder in the
MailMoversection includes aspace (e.g.
[Gmail].Sent Mail) there is currently not way to quotethe folder name such as to preserver the space in it. This change
replaces the standard
split()function with one that understandsquotes. For the above example, the following config entry works:
Fixes: #97
Signed-off-by: Nicolas Bock nicolasbock@gmail.com