Quote folder names in search query #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using folder names containing whitespace characters (see PR afewmail#206) the folder part of the notmuch search query needs to be quoted. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
|
Hello, |
|
@nicolasbock I guess this breaks when the output contains double quotes - we just enclose quotes, but not escape. Instead of this patch, can we escape while setting >>> import shlex
>>> print(shlex.quote("foo"))
foo
>>> print(shlex.quote("foo\""))
'foo"' |
nicolasbock
added a commit
to nicolasbock/afew
that referenced
this pull request
Jan 17, 2019
Follow on to PR afewmail#216: In cases where the folder name contains characters that should be quoted, use the `shlex.quote()` function to properly format the folder name. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
Merged
nicolasbock
added a commit
to nicolasbock/afew
that referenced
this pull request
Jan 17, 2019
Follow on to PR afewmail#216: In cases where the folder name contains characters that should be quoted, use the `shlex.quote()` function to properly format the folder name. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
nicolasbock
added a commit
to nicolasbock/afew
that referenced
this pull request
Jan 20, 2019
Follow on to PR afewmail#216: In cases where the folder name contains characters that should be quoted, use the `shlex.quote()` function to properly format the folder name. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using folder names containing whitespace characters (see PR #206)
the folder part of the notmuch search query needs to be quoted.
Signed-off-by: Nicolas Bock nicolasbock@gmail.com