Shell quote mail folder #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to be un-quoted again, as >>> import shlex
>>> print(shlex.quote("foo"))
foo
>>> print(shlex.quote("foo\""))
'foo"' |
flokli
requested changes
Jan 18, 2019
Follow on to PR afewmail#216: In cases where the folder name contains characters that should be quoted, use the `shlex.quote()` function to properly format the folder name. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
|
You are right, I missed that. It's fixed now. |
flokli
approved these changes
Jan 20, 2019
|
Thanks! |
|
@flokli For some reason this is not working. With this PR the search query does not return anything. Running But running that query in the shell works: Interestingly, when I revert the self.query = "folder:'{folder}' AND {subquery}"I get the same result as with this PR, i.e. the query does not return anything. The failure is reproducible with single quotes but I don't understand why. Do you have any suggestions? |
flokli
added a commit
to flokli/afew
that referenced
this pull request
Jan 28, 2019
shlex.quote quoted with single quotes, which is not supported by notmuch, so we have to quote and escape on our own followup of afewmail#218 (comment)
flokli
added a commit
to flokli/afew
that referenced
this pull request
Jan 28, 2019
shlex.quote quoted with single quotes, which is not supported by notmuch, so we have to quote and escape on our own followup of afewmail#218 (comment)
flokli
added a commit
to flokli/afew
that referenced
this pull request
Jan 28, 2019
shlex.quote quoted with single quotes, which is not supported by notmuch, so we have to quote and escape on our own followup of afewmail#218 (comment)
flokli
added a commit
that referenced
this pull request
Jan 29, 2019
shlex.quote quoted with single quotes, which is not supported by notmuch, so we have to quote and escape on our own followup of #218 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to PR #216:
In cases where the folder name contains characters that should be
quoted, use the
shlex.quote()function to properly format the foldername.
Signed-off-by: Nicolas Bock nicolasbock@gmail.com