Moves canvas initialization logic from a component to the scene. This… #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
reviewed
Aug 19, 2017
tests/core/scene/a-scene.test.js
Outdated
| @@ -385,7 +385,7 @@ suite('a-scene (without renderer)', function () { | |||
| var sceneEl = this.el; | |||
| sceneEl.innerHTML = 'NEW'; | |||
| sceneEl.reload(); | |||
| assert.equal(sceneEl.innerHTML, ''); | |||
| assert.equal(sceneEl.innerHTML, '<canvas class="a-canvas" data-aframe-canvas="true"></canvas>'); | |||
There was a problem hiding this comment.
We can do a more robust test with query selector rather than string check.
ngokevin
reviewed
Aug 19, 2017
src/core/scene/a-scene.js
Outdated
| @@ -449,6 +450,46 @@ module.exports.AScene = registerElement('a-scene', { | |||
| writable: window.debug | |||
| }, | |||
|
|
|||
| setupCanvas: { | |||
There was a problem hiding this comment.
We could move this out of the prototype to pure function. setupCanvas (sceneEl).
ngokevin
reviewed
Aug 19, 2017
src/core/scene/a-scene.js
Outdated
| // Set canvas on scene. | ||
| sceneEl.canvas = canvasEl; | ||
| sceneEl.emit('render-target-loaded', {target: canvasEl}); | ||
| // For unknown reasons a syncrhonous resize does not work on desktop when |
There was a problem hiding this comment.
can fix this typo on synchronous
|
r+wc |
|
FYI - this does not solve #2967 |
|
Yes, the |
… handle the case when calling enterVR before the renderer is initialized and also moves the canvas and renderer initialization before assets load (it's not a component anymore). This is a prequesite for a loading screen / spinner
dmarcos
pushed a commit
that referenced
this pull request
Aug 24, 2017
…traversal in Oculus Browser) (#2991) * Moves canvas initialization logic from a component to the scene. This handle the case when calling enterVR before the renderer is initialized and also moves the canvas and renderer initialization before assets load (it's not a component anymore). This is a prequesite for a loading screen / spinner * add vrdisplayactivate handler earlier than previously, as Oculus Browser fires it quite early on * remove redundant vrdisplayactivate listener in a-scene; improve comments
dmarcos
added a commit
that referenced
this pull request
Aug 24, 2017
…(vr2vr traversal in Oculus Browser)" (#2995) * Revert "Update master CDN URL. (https://rawgit.com/aframevr/aframe/fad376f/dist/aframe-master.min.js)" This reverts commit d576691. * Revert "Bump aframe-master dist/ builds. (c9c7bfc...5214a16)" This reverts commit fad376f. * Revert "extend PR #2985 (moved canvas init) to also solve issue #2967 (vr2vr traversal in Oculus Browser) (#2991)" This reverts commit 5214a16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… handle the case when calling enterVR before the renderer is initialized and also moves the canvas and renderer initialization before assets load (it's not a component anymore). This is a prequesite for a loading screen / spinner
Description:
Changes proposed: