Add functionality for checking for a new version #1064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2024 17:12
…'t return the version but some gibberish html element. Update the user update dialog.
swivelmargarita
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a commented out code for this functionality in utils.cpp, but when I tested that code it would evaluate the version wrong.
I tried to add a way to check if a new version available from the github releases. If so it redirects to the github release site.
If there's something I overlooked, I'd appreciate feedback, thanks.
I added a test case(it emulates when there's a new version) where the version obtained from github releases(69.420.0) is different than current version(2.0.0). It works as expected.
