Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for checking for a new version #1064

Closed
wants to merge 2 commits into from
Closed

Add functionality for checking for a new version #1064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7642315
Fix the behavior when running the check_for_updates function it doesn…
Apr 19, 2024
f532c00
Remove the line for emulating new version via hardcoding the version …
Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions pdf_viewer/utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2032,34 +2032,35 @@ float type_name_similarity_score(std::wstring name1, std::wstring name2) {
}

void check_for_updates(QWidget* parent, std::string current_version) {
QString latest_release_url = "https://github.com/ahrm/sioyek/releases/latest";
QNetworkAccessManager* manager = new QNetworkAccessManager;

QObject::connect(manager, &QNetworkAccessManager::finished, [=](QNetworkReply *reply) {
std::string reply_url = reply->url().toString().toStdString();
std::string expected_resolved_url_start = "https://github.com/ahrm/sioyek/releases/tag/v";
bool is_started_with_expected_url = reply_url.rfind(expected_resolved_url_start, 0) == 0;

//If the latest release url is not resolved into a url that starts with https://github.com/ahrm/sioyek/releases/tag/v
//Then there's a possibly a connection error or the release is in non-standard form.
//For example https://github.com/ahrm/sioyek/releases/tag/2143354635
if(reply_url == latest_release_url.toStdString() || !is_started_with_expected_url) {
return;
}

return;
//QString url = "https://github.com/ahrm/sioyek/releases/latest";
//QNetworkAccessManager* manager = new QNetworkAccessManager;

//QObject::connect(manager, &QNetworkAccessManager::finished, [=](QNetworkReply *reply) {
// std::string response_text = reply->readAll().toStdString();
// int first_index = response_text.find("\"");
// int last_index = response_text.rfind("\"");
// std::string url_string = response_text.substr(first_index + 1, last_index - first_index - 1);

// std::vector<std::wstring> parts;
// split_path(utf8_decode(url_string), parts);
// if (parts.size() > 0) {
// std::string version_string = utf8_encode(parts.back().substr(1, parts.back().size() - 1));

// if (version_string != current_version) {
// int ret = QMessageBox::information(parent, "Update", QString::fromStdString("Do you want to update from " + current_version + " to " + version_string + "?"),
// QMessageBox::Ok | QMessageBox::Cancel,
// QMessageBox::Cancel);
// if (ret == QMessageBox::Ok) {
// open_web_url(url);
// }
// }

// }
// });
//manager->get(QNetworkRequest(QUrl(url)));
std::string version_from_latest_release = reply_url.substr(expected_resolved_url_start.length(), reply_url.length() - 1);
if (version_from_latest_release != current_version) {
int ret = QMessageBox::information(parent, "Update",
QString::fromStdString( "New version of sioyek is available.\nDo you want to update from version "
+ current_version + " to version " + version_from_latest_release + "?"),
QMessageBox::Ok | QMessageBox::Cancel,
QMessageBox::Cancel);
if (ret == QMessageBox::Ok) {
open_web_url(latest_release_url);
}
}
}
);
manager->get(QNetworkRequest(QUrl(latest_release_url)));
}

QString expand_home_dir(QString path) {
Expand Down
Loading