Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LuaContext.hpp to not include misc/exception.hpp in Visual Studio 14.0 (2015) #10

Merged
merged 2 commits into from
Mar 16, 2017

Conversation

eliaskosunen
Copy link

Currently, LuaContext.hpp always includes the header file "misc/exception.hpp" if the compiler is MSVC++. This causes compilation errors in VS 14.0, since these functions are already defined in the standard library. Hence, a check against the version number is required.

@DouglasHeriot
Copy link

I have also fixed this in #2

@Habbie
Copy link
Collaborator

Habbie commented Mar 16, 2017

This says 1800, #2 says 1900, can either of you comment on which is correct?

@eliaskosunen
Copy link
Author

1800 means VS 2013 and 1900 means VS 2015. This PR says _MSC_VER <= 1800 which refers to VS 2013 initial release and before, #2 says _MSC_VER < 1900 which would refer to every version before VS 2015.

I'd say #2 is more correct, since it includes every minor release of VS 2013 as well.

@eliaskosunen
Copy link
Author

I changed this PR to contain a similar check to #2.

@Habbie
Copy link
Collaborator

Habbie commented Mar 16, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants