pass one tag for all remaining parameter types #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbuehler
force-pushed
the
rebase-pull-8
branch
from
7a4b42c
to
2d587e9
Compare
|
Oh, you've already done the rebase here. Well, thanks for that! If you still need my help, do let me know... |
|
@ThePhD it would be nice if you could confirm the modified patch still fixes the problem :) |
|
This PR is conflicted now. |
make tag a variadic template and use it to pass multiple types in one go to readIntoFunction. This fixes an Internal Compiler Error on VS 2015.2: - fixes ahupowerdns#7 - closes ahupowerdns#8
stbuehler
force-pushed
the
rebase-pull-8
branch
from
2d587e9
to
6ee3b8e
Compare
|
Conflicts should been resolved now. |
|
@ThePhD can you test this patch? |
|
I basically only use luawrapper to compile some benchmark code (found here: https://github.com/ThePhD/lua-bench). It's not extensive by any means (only compiling with the latest VC++ in Visual Studio, honestly). Your fix works out: 👍 💯 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased #8, removed changes to
exception.hppas they should have been fixed in #10.also doesn't include the moving of
enable_iffrom auto return type to template type parameter (if needed: stbuehler@rebase-pull-8-add has the change in a separate commit).