fix: limit sqlalchemy<1.4.45 #5871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqla 1.4.45 introduced a breaking change resulting in two test failures FAILED tests/orm/test_querybuilder.py::TestRepresentations::test_as_sql_literal_quote - sqlalchemy.exc.CompileError: No literal value renderer is available for literal value "['Si']" with datatype JSONB FAILED tests/orm/test_querybuilder.py::test_analyze_query - sqlalchemy.exc.CompileError: No literal value renderer is available for literal value "['x', 1]" with datatype JSONB
ltalirz
force-pushed
the
fix/5857/sqlalchemy-break
branch
from
c6d347b to
3e18a39
Compare
|
Note: in the meanwhile sqlalchemy 1.4.46 is out with a couple of fixes, some of which look like they could be related, but the nightly aiida-core test install workflow still fails with sqlalchemy 1.4.46 |
|
@aiidateam/dependency-manager |
my local yapf did not pick up on this...
|
@sphuber I think this one is important to merge relatively soon + make a new release, since AiiDA installations created after december 11th 2022 are likely broken in the way the tests point out |
|
Follow-up PR #5873 is also ready to go after this one, which will fix the conda-based install |
|
Superseded by #5875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqla 1.4.45 introduced a breaking change resulting in two test failures
FAILED tests/orm/test_querybuilder.py::TestRepresentations::test_as_sql_literal_quote - sqlalchemy.exc.CompileError: No literal value renderer is available for literal value "['Si']" with datatype JSONB
FAILED tests/orm/test_querybuilder.py::test_analyze_query - sqlalchemy.exc.CompileError: No literal value renderer is available for literal value "['x', 1]" with datatype JSONB