Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use setup-miniconda in test-install workflow #5873

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix: use setup-miniconda in test-install workflow #5873

merged 1 commit into from
Jan 27, 2023

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jan 26, 2023 •
edited by sphuber
Loading

Fixes #5872

It appears conda-incubator/setup-miniconda is more up to date (last release 12/2022) than s-weigand/setup-conda (last release 05/2022).

Also, we don't actually need all of conda + the first step is to install
mamba (which I guess means uninstalling a number of tools in a
full-blown conda installation).

Builds on top of #5871

@ltalirz ltalirz mentioned this pull request Jan 27, 2023
Closed
@ltalirz
fix: use setup-miniconda in test-install workflow
1377f68 
Installation of mamba resulted in irresolvable conflict.
This is fixed by switching to installing only the libmamba-solver and
sticking with conda.

Also, it appears conda-incubator/setup-miniconda is more up to date (last
release 12/2022) than s-weigand/setup-conda (last release 05/2022), so
we switch to that.
@ltalirz ltalirz force-pushed the fix/5872/conda-workflow branch from bf3a62b to 1377f68 Compare January 27, 2023 09:58
@ltalirz ltalirz marked this pull request as ready for review January 27, 2023 09:58
@sphuber
Copy link
Contributor

sphuber commented Jan 27, 2023

Thanks @ltalirz . I switched to using mamba in 6da1333 since the build was failing with conda due to it running out of memory. Any idea why this may no longer apply? Are the lines:

conda install -n base conda-libmamba-solver
conda config --set solver libmamba

essentially still using part of mamba to keep things working?

@ltalirz
Copy link
Member Author

ltalirz commented Jan 27, 2023

Yes, this is using the mambasolver under the hood.

It's one of the workarounds suggested in conda-incubator/setup-miniconda#274 to the fact that mamba is currently uninstallable from conda-forge

@ltalirz ltalirz requested a review from sphuber January 27, 2023 10:25
sphuber
sphuber approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ltalirz

@sphuber sphuber merged commit 9898b47 into aiidateam:main Jan 27, 2023
@sphuber sphuber deleted the fix/5872/conda-workflow branch January 27, 2023 10:51
@sphuber sphuber mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conda install workflow broken
2 participants
@ltalirz @sphuber