Skip to content

Commit

Permalink
fix tests: changed random bucket name to full lowercase to match new …
Browse files Browse the repository at this point in the history
…AWS specifications (#919)

Co-authored-by: simonsaliba <simon.saliba@terality.com>
  • Loading branch information
simon-saliba and simon-saliba authored Mar 2, 2022
1 parent 4021585 commit 833694a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def random_name():
The string contains only symbols allowed for s3 buckets
(alphanumeric, dot and hyphen).
"""
return ''.join(random.sample(string.ascii_letters, k=40))
return ''.join(random.sample(string.ascii_lowercase, k=26))


def assert_status_code(response, status_code):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_basic_s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ async def test_presign_sigv4(s3_client, bucket_name, aio_session,
'get_object', Params={'Bucket': bucket_name, 'Key': key})
msg = "Host was suppose to be the us-east-1 endpoint, " \
"instead got: %s" % presigned_url
assert presigned_url.startswith('https://s3.amazonaws.com/%s/%s'
assert presigned_url.startswith('https://%s.s3.amazonaws.com/%s'
% (bucket_name, key)), msg

# Try to retrieve the object using the presigned url.
Expand Down

0 comments on commit 833694a

Please sign in to comment.