fix tests: changed random bucket name to full lowercase #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the random bucket naming generation used in tests to match the new AWS S3 bucket naming specifications.
According to documentation [https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html],
bucket names can consist only of lowercase letters, numbers, dots (.), and hyphens (-).
S3 bucket url skeletons have also changed to take the following form:
https://bucket-name.s3.Region.amazonaws.com/key-name
according to source [https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-bucket-intro.html]
These couple of changes have been making a number of unit tests in
test_basic_s3.py
failing with error: InvalidBucketName, and NoSuckBucket.Description of Change
Change required to make all unit tests under test_basic_s3.py pass.
Changes include:
Assumptions
Replace this text with any assumptions made (if any)
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions