-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decompress gzipped responses #430
Conversation
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 87.24% 87.11% -0.13%
==========================================
Files 8 8
Lines 486 489 +3
==========================================
+ Hits 424 426 +2
- Misses 62 63 +1
Continue to review full report at Codecov.
|
Good catch, previous versions disabled gzip explicitly by adding
|
Original issue was crc32 checks on dynamo see comment here https://github.com/aio-libs/aiobotocore/pull/425/files |
we need to ensure the following:
|
From my own tests it doesn't seem to be conflicting with #295 at least, as it seems to be a streaming output that sets |
@kalaspuff could to try by putting back this line: https://github.com/aio-libs/aiobotocore/pull/425/files#diff-e941ba728e64131911465db18f803157L278 looks like jettify is working on a revert |
@kalaspuff please try https://pypi.python.org/pypi/aiobotocore/0.5.1 feel free to open new issue |
@jettify Works like a charm, thanks! |
With aiobotocore 0.5.0 it now also accepts content encoding 'gzip' but doesn't use aiohttp auto_decompress which makes larger responses from AWS end up compressed when passed to botocore parsers.
In my case I got this issue after upgrading to 0.5.0 and when doing a
list_topics()
call on an SNS aiobotocore client and had lots of topics in the response data.