-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequestInfo
change to a named tuple broke BC
#9866
Labels
Comments
fyi this is breaking for https://github.com/pnuckowski/aioresponses |
Please see pnuckowski/aioresponses#262 |
potiuk
added a commit
to potiuk/airflow
that referenced
this issue
Nov 13, 2024
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be reverted when pnuckowski/aioresponses#262 is merged and released
potiuk
added a commit
to potiuk/airflow
that referenced
this issue
Nov 14, 2024
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be reverted when pnuckowski/aioresponses#262 is merged and released
potiuk
added a commit
to potiuk/airflow
that referenced
this issue
Nov 14, 2024
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be reverted when pnuckowski/aioresponses#262 is merged and released
potiuk
added a commit
to apache/airflow
that referenced
this issue
Nov 14, 2024
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be reverted when pnuckowski/aioresponses#262 is merged and released
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this issue
Nov 14, 2024
Because of aio-libs/aiohttp#9866 some tests are failing. This PR can be reverted when pnuckowski/aioresponses#262 is merged and released
bdraco
added a commit
that referenced
this issue
Nov 14, 2024
It was unexpected that this object was being created directly outside of aiohttp internals. While it looks like its only used for mocking downstream, we can accomodate that by subclassing the NamedTuple and providing a `__new__` while keeping the faster `tuple.__new__` internally. fixes #9866
bdraco
added a commit
that referenced
this issue
Nov 14, 2024
It was unexpected that this object was being created directly outside of aiohttp internals. While it looks like its only used for mocking downstream, we can accomodate that by subclassing the NamedTuple and providing a `__new__` while keeping the faster `tuple.__new__` internally. fixes #9866
My initial call on this was we didn't want to change it because we don't expect these objects to be created externally but since there is no great alternative to do the mocking, I opened #9873 |
1 task
kaxil
added a commit
to astronomer/airflow
that referenced
this issue
Nov 14, 2024
kaxil
added a commit
to astronomer/airflow
that referenced
this issue
Nov 14, 2024
Bump `aiohttp` to `3.11.1` aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment) https://pypi.org/project/aiohttp/3.11.1/
kaxil
added a commit
to apache/airflow
that referenced
this issue
Nov 14, 2024
Bump `aiohttp` to `3.11.1` aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment) https://pypi.org/project/aiohttp/3.11.1/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Existing usage of aiohttp 3.10 no longer works with aiohttp 3.13, causing the following error:
TypeError: RequestInfo.__new__() missing 1 required positional argument: 'real_url'
To Reproduce
Run the following code:
With aiohttp 3.10.11, this exits without an error. With aiohttp 3.11.0, this raises
TypeError: RequestInfo.__new__() missing 1 required positional argument: 'real_url'
Expected behavior
The expected behavior is for no error to be raised, by
real_url
not being a required argument.Logs/tracebacks
Python Version
3.13
aiohttp Version
3.11.0
multidict Version
6.1.0
propcache Version
0.2.0
yarl Version
1.17.1
OS
Ubuntu 24.04
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: